Optimize CreateBucket by Omitting LocationConstraint for us-east-1

[0xJacobs]

The CreateBucket function currently sets LocationConstraint in CreateBucketConfiguration for all regions, including us-east-1. According to the Amazon S3 API Reference for CreateBucket, this is redundant for us-east-1:

"If you don’t specify a LocationConstraint, the bucket is created in the US East (N. Virginia) Region (us-east-1) by default."

Specifying LocationConstraint for us-east-1 is unnecessary, as the AWS SDK defaults to this region when CreateBucketConfiguration is omitted. This optimization aligns the code with AWS best practices and improves clarity.

Proposed Solution

Update the CreateBucket function to conditionally omit CreateBucketConfiguration when the region is us-east-1:

func (s *Client) CreateBucket(ctx context.Context, name, region string) error {
    input := &s3.CreateBucketInput{
        Bucket: aws.String(name),
    }
    if region != "us-east-1" {
        input.CreateBucketConfiguration = &types.CreateBucketConfiguration{
            LocationConstraint: types.BucketLocationConstraint(region),
        }
    }
    _, err := s.s3Client.CreateBucket(ctx, input)
    return err
}

[0xJacobs]

Current Code is:

❌ Redundant

❌ Risky (leads to 400 Bad Request from AWS sometimes)

❌ Not aligned with best practices