github #147: Clean up some leaked variables in completion functions

Author: kevincox

ChangeLog

@@ -1,5 +1,9 @@
 2025-10-23  Oliver Kiddle  <[email protected]>
 
+	* Kevin Cox: github #147: Completion/Unix/Command/_git,
+	Completion/Unix/Command/_ssh, Completion/Unix/Type/_hosts:
+	Clean up some leaked variables in completion functions
+
 	* 53999: Src/module.c: remove further remnants of ansi2knr
 	support from AIX specific code
 

Completion/Unix/Command/_git

@@ -7181,7 +7181,7 @@ __git_remote_branch_names () {
 __git_remote_branch_names_noprefix () {
   declare -a heads
 
-  branch_names=(${${${${(f)"$(_call_program remote-branch-refs-noprefix git for-each-ref --format='"%(refname)"' refs/remotes 2>/dev/null)"}#refs/remotes/}#*/}:#HEAD})
+  local branch_names=(${${${${(f)"$(_call_program remote-branch-refs-noprefix git for-each-ref --format='"%(refname)"' refs/remotes 2>/dev/null)"}#refs/remotes/}#*/}:#HEAD})
   __git_command_successful $pipestatus || return 1
 
   __git_describe_commit branch_names remote-branch-names-noprefix 'remote branch name' "$@"

Completion/Unix/Command/_ssh

@@ -3,7 +3,7 @@
 # TODO: sshd, ssh-keysign
 
 _ssh () {
-  local curcontext="$curcontext" state line expl suf arg ret=1
+  local curcontext="$curcontext" state line lstate expl suf arg ret=1
   local args sigargs common common_transfer options algopt tmp p1 file cmn cmds sdesc tdesc
   typeset -A opt_args tsizes
 

Completion/Unix/Type/_hosts

@@ -41,7 +41,7 @@ if ! zstyle -a ":completion:${curcontext}:hosts" hosts _hosts; then
 
     for khostfile in $khostfiles; do
       if [[ -r $khostfile ]]; then
-        khosts=(${(s/,/j/,/u)${(f)"$(<$khostfile)"}%%[ |#]*})
+        local khosts=(${(s/,/j/,/u)${(f)"$(<$khostfile)"}%%[ |#]*})
 
         # known_hosts syntax supports the host being in the form [hostname]:port
         # The filter below extracts the hostname from lines using this format.