more accurately model how build system modules work #2510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Techatrix
force-pushed
the
techatrix/model-build-system
branch
from
31a1a3a to
725af1e
Compare
The completions are ordered like this: - the `std` module - the `builtin` module - the `root` module - other modules - files This is the same as the source.organizeImports code action.
This allows the build runner check to handle paths that are in the local or global zig cache.
Techatrix
force-pushed
the
techatrix/model-build-system
branch
from
725af1e to
31481f3
Compare
Contributor
fyi - it seems that can't really be relied upon https://gist.github.com/dotcarmen/7f186613f1f839427a839c33306af9dd <- the output is: what happens when a module is imported by multiple roots? i think it's best to not resolve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZLS had an inaccurate view of how modules work in the build system. It would previously merge every module in the entire build graph into one single module which can easily lead to incorrect results in any non trivial project that contains multiple modules. This PR will keep track of each individual module so that analysis can differentiate between them just like how the compiler does it.
Some examples of what has been improved:
@import("root")now actually figures out in which module a given file is in.@importwill only show the modules that have been directly added to the module that the current file belongs to@import("some_name")will resolve the correct module if there are multiple modules that have imported different modules with"some_name"as their name.One issue this PR doesn't fully address is when there are multiple modules with the same root source file that have conflicting definitions. This is only achievable using multiple compilation units because Zig fortunately disallows sharing a root source file within a single compilation unit.
Related PR #2308