Skip to content

Conversation

@eskimor
Copy link

@eskimor eskimor commented Nov 22, 2025

Ensure we properly make sure opening the uri actually worked to ensure we always fallback if it does not.

Release Notes:

Fixed: When opening URIs on Linux (e.g. on Sign in) properly fallback to xdg-open in case the xdg portal failed. The fallback existed already, but was not always triggered as some errors had been ignored.

@cla-bot
Copy link

cla-bot bot commented Nov 22, 2025

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: eskimor.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@zed-industries-bot
Copy link

zed-industries-bot commented Nov 22, 2025

Warnings
⚠️

This PR is missing release notes.

Please add a "Release Notes" section that describes the change:

Release Notes:

- Added/Fixed/Improved ...

If your change is not user-facing, you can use "N/A" for the entry:

Release Notes:

- N/A

Generated by 🚫 dangerJS against c220fef

to ensure fallback is triggered on failure.
@eskimor eskimor force-pushed the fix-open-uri-fallback branch from 301fffe to fb22fab Compare November 22, 2025 17:15
@cla-bot
Copy link

cla-bot bot commented Nov 22, 2025

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: eskimor.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@maxdeviant maxdeviant changed the title Properly check for success on xdg-portal open uri Properly check for success on xdg-portal open URI Nov 22, 2025
@cla-bot
Copy link

cla-bot bot commented Nov 22, 2025

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: eskimor.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Community PRs

Development

Successfully merging this pull request may close these issues.

3 participants