This repository was archived by the owner on Jan 17, 2020. It is now read-only.
Add a subscription to SDL.Event.TextInputEvent#135
Open
geezee wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on a keyboard that is not the US standard layout (QWERTZ) for example SHIFT+4 is not $. So I cannot detect keys beyond the ones in Helm.Keyboard, and that's a serious limitation to what I'm developing.
Therefore I propose this patch that exposes a subscription
Helm.Keyboard.typing :: Engine e => (Data.Text.Text -> a) -> Sub e awhich gets called whenever a key (or key combination) gets pressed with the argument being the resulting character. For example pressing shift and x would traditionally call twiceHelm.Keyboard.ups, with this patch it will also callHelm.Keyboard.typingonce with the text being X.I also modified the helm-example-hello executable to demo this subscription. You can find the code on the branch
example-textinputeventof my fork (or directly here)