spread-shellcheck

#!/usr/bin/env python3

# Copyright (C) 2018 Canonical Ltd
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License version 3 as
# published by the Free Software Foundation.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program.  If not, see <http://www.gnu.org/licenses/>.

import logging
import os
import subprocess
import argparse

import yaml


# default shell for shellcheck
SHELLCHECK_SHELL = os.getenv('SHELLCHECK_SHELL', 'bash')
# set to non-empty to ignore all errors
NO_FAIL = os.getenv('NO_FAIL', None)
# set to non empty to enable 'set -x'
D = os.getenv('D', None)
# set to non-empty to enable verbose logging
V = os.getenv('V', None)
# file with list of test file that must successfully validate, one file per line
MUST_PASS = os.getenv('MUST_PASS', None)

# names of sections
SECTIONS = ['prepare', 'prepare-each', 'restore', 'restore-each',
            'debug', 'debug-each', 'execute', 'repack']

def parse_arguments():
    parser = argparse.ArgumentParser(description='spread shellcheck helper')
    parser.add_argument('-s', '--shell', default='bash',
                        help='shell')
    parser.add_argument('-n', '--no-errors', action='store_true',
                        default=False, help='ignore all errors ')
    parser.add_argument('-v', '--verbose', action='store_true',
                        default=False, help='verbose logging')
    parser.add_argument('--must-pass', default=None,
                        help='file with list of files that are required to be valid (regardless of --no-errors flag)')
    parser.add_argument('paths', nargs='+', help='paths to check')
    return parser.parse_args()


class ShellcheckRunError(Exception):
    def __init__(self, stderr):
        super().__init__()
        self.stderr = stderr


class ShellcheckError(Exception):
    def __init__(self):
        super().__init__()
        self.sectionerrors = {}

    def addfailure(self, section, error):
        self.sectionerrors[section] = error

    def __len__(self):
        return len(self.sectionerrors)


class ShellcheckFailures(Exception):
    def __init__(self, failures=None):
        super().__init__()
        self.failures = set()
        if failures:
            self.failures = set(failures)

    def merge(self, otherfailures):
        self.failures = self.failures.union(otherfailures.failures)

    def __len__(self):
        return len(self.failures)

    def contains(self, other):
        return len(self.failures.intersection(other)) > 0


def checksection(data):
    proc = subprocess.Popen("shellcheck -s {} -x -".format(SHELLCHECK_SHELL),
                            stdout=subprocess.PIPE,
                            stdin=subprocess.PIPE,
                            shell=True)
    stdout, _ = proc.communicate(input=data.encode('utf-8'), timeout=10)
    if proc.returncode != 0:
        logging.debug('shellcheck failed')
        raise ShellcheckRunError(stdout)


def checkfile(path):
    logging.debug("checking file %s", path)
    with open(path) as inf:
        data = yaml.load(inf)

    errors = ShellcheckError()

    for section in SECTIONS:
        if section not in data:
            continue

        try:
            logging.debug("checking section %s", section)
            checksection(data[section])
        except ShellcheckRunError as serr:
            logging.debug("%s: shellcheck failed in section '%s'", path, section)
            errors.addfailure(section, serr.stderr.decode('utf-8'))

    if path.endswith('spread.yaml') and 'suites' in data:
        # check suites
        for suite in data['suites'].keys():
            logging.debug('checking suite %s', suite)
            for section in SECTIONS:
                if section not in data['suites'][suite]:
                    continue
                try:
                    logging.debug("checking section %s", section)
                    checksection(data['suites'][suite][section])
                except ShellcheckRunError as serr:
                    errors.addfailure('suites/' + suite + '/' + section,
                                      serr.stderr.decode('utf-8'))

    if errors:
        raise errors


def findfiles(indir):
    for root, _, files in os.walk(indir, topdown=True):
        for name in files:
            if name in ['spread.yaml', 'task.yaml']:
                yield os.path.join(root, name)


def checkpath(loc):
    if os.path.isdir(loc):
        # setup iterator
        locations = findfiles(loc)
    else:
        locations = [loc]

    failed = []
    for entry in locations:
        try:
            checkfile(entry)
        except ShellcheckError as serr:
            logging.error("shellcheck failed for file %s in sections: %s; error log follows",
                          entry, ', '.join(serr.sectionerrors.keys()))
            for section, error in serr.sectionerrors.items():
                logging.error("%s: section '%s':\n%s", entry, section, error)
            failed.append(entry)

    if failed:
        raise ShellcheckFailures(failures=failed)


def loadmusts(mustpath):
    musts = set()
    with open(mustpath) as mf:
        for line in mf.readlines():
            if not line.startswith('#'):
                musts.add(line.strip())
    return musts


def main(opts):
    paths = opts.paths or ['.']
    failures = ShellcheckFailures()
    for pth in paths:
        try:
            checkpath(pth)
        except ShellcheckFailures as sf:
            failures.merge(sf)

    if failures:
        if opts.must_pass:
            musts = loadmusts(opts.must_pass)

            if failures.contains(musts):
                logging.error('validation failed for required files')
                raise SystemExit(1)

        logging.debug('must validate: %s', musts)
        if NO_FAIL or opts.no_errors:
            logging.warning("ignoring errors")
        else:
            raise SystemExit(1)


if __name__ == '__main__':
    opts = parse_arguments()
    if opts.verbose or D or V:
        lvl = logging.DEBUG
    else:
        lvl = logging.INFO
    logging.basicConfig(level=lvl)

    if MUST_PASS:
        opts.must_pass = MUST_PASS

    if NO_FAIL:
        opts.no_errors = True

    main(opts)