feat(VDisk): add replication progress, remaining time, donors info (#2588)

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: antonkovalenko <[email protected]>
Co-authored-by: adameat <[email protected]>
Co-authored-by: Alexey Efimov <[email protected]>
Co-authored-by: Elena Makarova <[email protected]>

Author: 4 people

src/components/VDiskInfo/VDiskInfo.tsx

@@ -3,15 +3,20 @@ import React from 'react';
 import {Flex} from '@gravity-ui/uikit';
 
 import {getVDiskPagePath} from '../../routes';
+import {EVDiskState} from '../../types/api/vdisk';
 import {valueIsDefined} from '../../utils';
 import {cn} from '../../utils/cn';
-import {formatStorageValuesToGb} from '../../utils/dataFormatters/dataFormatters';
+import {
+    formatStorageValuesToGb,
+    formatUptimeInSeconds,
+} from '../../utils/dataFormatters/dataFormatters';
 import {createVDiskDeveloperUILink} from '../../utils/developerUI/developerUI';
 import {getSeverityColor} from '../../utils/disks/helpers';
 import type {PreparedVDisk} from '../../utils/disks/types';
 import {useIsUserAllowedToMakeChanges} from '../../utils/hooks/useIsUserAllowedToMakeChanges';
 import {bytesToSpeed} from '../../utils/utils';
 import {InfoViewer} from '../InfoViewer';
+import {InternalLink} from '../InternalLink';
 import {LinkWithIcon} from '../LinkWithIcon/LinkWithIcon';
 import {ProgressViewer} from '../ProgressViewer/ProgressViewer';
 import {StatusIcon} from '../StatusIcon/StatusIcon';
@@ -46,6 +51,9 @@ export function VDiskInfo<T extends PreparedVDisk>({
         FrontQueues,
         Guid,
         Replicated,
+        ReplicationProgress,
+        ReplicationSecondsRemaining,
+        Donors,
         VDiskState,
         VDiskSlotId,
         Kind,
@@ -130,6 +138,31 @@ export function VDiskInfo<T extends PreparedVDisk>({
             value: Replicated ? vDiskInfoKeyset('yes') : vDiskInfoKeyset('no'),
         });
     }
+    // Only show replication progress and time remaining when disk is not replicated and state is OK
+    if (Replicated === false && VDiskState === EVDiskState.OK) {
+        if (valueIsDefined(ReplicationProgress)) {
+            rightColumn.push({
+                label: vDiskInfoKeyset('replication-progress'),
+                value: (
+                    <ProgressViewer
+                        value={Math.round(ReplicationProgress * 100)}
+                        percents
+                        colorizeProgress={true}
+                        capacity={100}
+                    />
+                ),
+            });
+        }
+        if (valueIsDefined(ReplicationSecondsRemaining)) {
+            const timeRemaining = formatUptimeInSeconds(ReplicationSecondsRemaining);
+            if (timeRemaining) {
+                rightColumn.push({
+                    label: vDiskInfoKeyset('replication-time-remaining'),
+                    value: timeRemaining,
+                });
+            }
+        }
+    }
     if (valueIsDefined(VDiskSlotId)) {
         rightColumn.push({label: vDiskInfoKeyset('slot-id'), value: VDiskSlotId});
     }
@@ -153,6 +186,45 @@ export function VDiskInfo<T extends PreparedVDisk>({
         });
     }
 
+    // Show donors list when replication is in progress
+    if (Replicated === false && VDiskState === EVDiskState.OK && Donors?.length) {
+        const donorLinks = Donors.map((donor, index) => {
+            const {
+                StringifiedId: id,
+                NodeId: dNodeId,
+                PDiskId: dPDiskId,
+                VDiskSlotId: dVSlotId,
+            } = donor;
+
+            if (!id || !dVSlotId || !dNodeId || !dPDiskId) {
+                return null;
+            }
+
+            const vDiskPath = getVDiskPagePath({
+                nodeId: dNodeId,
+                pDiskId: dPDiskId,
+                vDiskSlotId: dVSlotId,
+            });
+
+            return (
+                <InternalLink key={index} to={vDiskPath}>
+                    {id}
+                </InternalLink>
+            );
+        }).filter(Boolean);
+
+        if (donorLinks.length) {
+            rightColumn.push({
+                label: vDiskInfoKeyset('donors'),
+                value: (
+                    <Flex direction="column" gap={1}>
+                        {donorLinks}
+                    </Flex>
+                ),
+            });
+        }
+    }
+
     const diskParamsDefined =
         valueIsDefined(PDiskId) && valueIsDefined(NodeId) && valueIsDefined(VDiskSlotId);
 

src/components/VDiskInfo/i18n/en.json

@@ -8,6 +8,9 @@
   "instance-guid": "Instance GUID",
 
   "replication-status": "Replicated",
+  "replication-progress": "Replication Progress",
+  "replication-time-remaining": "Time Remaining",
+  "donors": "Donors",
   "state-status": "VDisk State",
   "space-status": "Disk Space",
 

src/components/VDiskPopup/VDiskPopup.tsx

@@ -4,9 +4,11 @@ import {Flex, Label} from '@gravity-ui/uikit';
 
 import {selectNodesMap} from '../../store/reducers/nodesList';
 import {EFlag} from '../../types/api/enums';
+import {EVDiskState} from '../../types/api/vdisk';
 import {valueIsDefined} from '../../utils';
 import {cn} from '../../utils/cn';
 import {EMPTY_DATA_PLACEHOLDER} from '../../utils/constants';
+import {formatUptimeInSeconds} from '../../utils/dataFormatters/dataFormatters';
 import {createVDiskDeveloperUILink} from '../../utils/developerUI/developerUI';
 import {isFullVDiskData} from '../../utils/disks/helpers';
 import type {PreparedVDisk, UnavailableDonor} from '../../utils/disks/types';
@@ -73,6 +75,8 @@ const prepareVDiskData = (data: PreparedVDisk, withDeveloperUILink?: boolean) =>
         DiskSpace,
         FrontQueues,
         Replicated,
+        ReplicationProgress,
+        ReplicationSecondsRemaining,
         UnsyncedVDisks,
         AllocatedSize,
         ReadThroughput,
@@ -125,8 +129,27 @@ const prepareVDiskData = (data: PreparedVDisk, withDeveloperUILink?: boolean) =>
         vdiskData.push({label: 'FrontQueues', value: FrontQueues});
     }
 
-    if (Replicated === false) {
+    if (Replicated === false && VDiskState === EVDiskState.OK) {
         vdiskData.push({label: 'Replicated', value: 'NO'});
+
+        // Only show replication progress and time remaining when disk is not replicated and state is OK
+        if (valueIsDefined(ReplicationProgress)) {
+            const progressPercent = Math.round(ReplicationProgress * 100);
+            vdiskData.push({
+                label: 'Progress',
+                value: `${progressPercent}%`,
+            });
+        }
+
+        if (valueIsDefined(ReplicationSecondsRemaining)) {
+            const timeRemaining = formatUptimeInSeconds(ReplicationSecondsRemaining);
+            if (timeRemaining) {
+                vdiskData.push({
+                    label: 'Remaining',
+                    value: timeRemaining,
+                });
+            }
+        }
     }
 
     if (UnsyncedVDisks) {

src/utils/disks/prepareDisks.ts

@@ -1,3 +1,5 @@
+import {isNil} from 'lodash';
+
 import {valueIsDefined} from '..';
 import type {TPDiskStateInfo} from '../../types/api/pdisk';
 import type {TVDiskStateInfo, TVSlotId} from '../../types/api/vdisk';
@@ -63,7 +65,26 @@ export function prepareWhiteboardVDiskData(
     const StringifiedId = stringifyVdiskId(VDiskId);
 
     const preparedDonors = Donors?.map((donor) => {
-        return prepareWhiteboardVDiskData({...donor, DonorMode: true});
+        // Handle both TVDiskStateInfo and TVSlotId donor types
+        if (isFullVDiskData(donor)) {
+            // Full VDisk data
+            return prepareWhiteboardVDiskData({...donor, DonorMode: true});
+        } else {
+            // TVSlotId data - create a minimal PreparedVDisk
+            const {NodeId: dNodeId, PDiskId: dPDiskId, VSlotId: vSlotId} = donor;
+            const stringifiedId =
+                !isNil(dNodeId) && !isNil(dPDiskId) && !isNil(vSlotId)
+                    ? `${dNodeId}-${dPDiskId}-${vSlotId}`
+                    : '';
+
+            return {
+                NodeId: dNodeId,
+                PDiskId: dPDiskId,
+                VDiskSlotId: vSlotId,
+                StringifiedId: stringifiedId,
+                DonorMode: true,
+            };
+        }
     });
 
     return {