XWIKI-17296: Inconsistent dropdown behaviour between object and class editor #4860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… editor * Removed a minor bug from the `Add property` button. When there was no name set for the property it would submit the edit form and open the preview of the doc?? AFAIU the type on this button should have been `button` (action unrelated to the form) instead of `submit` (the button purpose is to submit the form -- here the edition of the page). * Removed a minor bug where clicking on the reordering handle would also expand/collapse the section. * Fixed the default state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-17296
Changes
Description
Clarifications
expandCollapseMetaPropertyin a way that would keep backwards compatibility. When providing only the first argument, the result of this function is the same as it was.button(action unrelated to the form) instead ofsubmit(the button purpose is to submit the form -- here the edition of the page). (fix oneditclass.vmL143) Note that hiting theEnterkey on the input still submits the edition form... Since it's not the main concern of the ticket, I'm not providing further solution for this problem here.dataeditors.jsL697)Screenshots & Video
Here is a video demo of my local instance with the PR applied. Everything mentionned above and in the ticket description behaves as expected.
2025-12-01.16-16-37.mp4
Executed Tests
Manual tests, see video above.
Checked the updated files with SonarQube, no new codestyle/quality violation.
Successfully built the quality profiles of modules with changes:
mvn clean install -f xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/ -Pqualitymvn clean install -f xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources -PqualitySuccessfully passed docker tests
mvn clean install -f xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker, which containsEditClassITthat use theClassEditPageobject. (I tried to use a pattern but didn't get it to work so it just ran all the flamingo tests in about 25 minutes).Expected merging strategy