Skip to content

Desktop follow-ups from v0.10.0 release review #113

Description

@xr843

Non-blocking findings triaged as follow-ups during the v0.10.0 final whole-branch review (PRs #108#112).

Re-triaged 2026-08-18 against main. PRs #123 / #124 closed five of the eight. Each line below was checked against the current code, not against the commit message.


✅ Fixed

  • --help (and any unknown arg) silently launches the GUI--help now prints usage and exits 0; unknown args exit 2. Fixed in 9a9f09d fix(desktop): reject invalid launch arguments. Covered by desktop/tests/desktop_args_cli.rs::help_exits_zero_without_launching_a_window.
  • TraceStore::save_to_path is a non-atomic fs::write truncate — now tempfile::NamedTempFile::new_in(parent) + persist. Fixed in ee20b34 fix(desktop): make trace persistence atomic, with the concurrent-writer half in 9843746 fix(desktop): serialize baseline trace writers.
  • No automated failure-path test for fail <slug> / exit 1desktop/tests/baseline_cli.rs now has baseline_lock_contention_fails_clearly and baseline_flag_with_no_discovered_skills_fails_loudly_instead_of_reporting_zero_of_zero.
  • dry_run is inferred from the absence of a passed key — now corroborated: a dry-run suite is rejected unless graded counts are omitted and every status is dry_run (trace.rs, "invalid dry-run suite: graded counts must be omitted and every status must be dry_run"). Fixed in f7b2198 fix(desktop): reject invalid fidelity suites.
  • {"error": ...} suites are silently dropped from evaluation_results — an errored suite is now a modelled outcome (EvaluationSuiteOutcome::Error), distinguishable from "never ran". Fixed in 84b1fb0 fix(desktop): harden evaluation evidence edges.

⬜ Still open — verified, not assumed

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions