From 70ed609358a037d3adde96f36bbb666ff094b8a4 Mon Sep 17 00:00:00 2001 From: victormattosvm Date: Tue, 25 Jan 2022 22:53:16 -0300 Subject: [PATCH 1/4] [Fix] Error when switching percent to fixed --- includes/mutation/class-coupon-create.php | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/includes/mutation/class-coupon-create.php b/includes/mutation/class-coupon-create.php index 5b853d734..f5f494193 100644 --- a/includes/mutation/class-coupon-create.php +++ b/includes/mutation/class-coupon-create.php @@ -209,6 +209,13 @@ public static function mutate_and_get_payload( $input, AppContext $context, Reso case 'description': $coupon->set_description( wp_filter_post_kses( $value ) ); break; + case 'amount': + if ( $coupon_args['discountType'] == 'PERCENT' ){ + $coupon->set_discount_type( 'PERCENT' ); + } + + $coupon->set_amount( $value ); + break; default: if ( is_callable( array( $coupon, "set_{$key}" ) ) ) { $coupon->{"set_{$key}"}( $value ); From ddb29aa7dac009748f453386c45cf61e45659f38 Mon Sep 17 00:00:00 2001 From: victormattosvm Date: Tue, 25 Jan 2022 23:10:46 -0300 Subject: [PATCH 2/4] [Fix] Check if discountType is being sent --- includes/mutation/class-coupon-create.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/mutation/class-coupon-create.php b/includes/mutation/class-coupon-create.php index f5f494193..556c25b38 100644 --- a/includes/mutation/class-coupon-create.php +++ b/includes/mutation/class-coupon-create.php @@ -210,7 +210,7 @@ public static function mutate_and_get_payload( $input, AppContext $context, Reso $coupon->set_description( wp_filter_post_kses( $value ) ); break; case 'amount': - if ( $coupon_args['discountType'] == 'PERCENT' ){ + if ( $coupon_args['discountType'] && $coupon_args['discountType'] == 'PERCENT' ){ $coupon->set_discount_type( 'PERCENT' ); } From 81a1e65d236f1b68ca55e54eb26d59b39a5d1e95 Mon Sep 17 00:00:00 2001 From: victormattosvm Date: Tue, 25 Jan 2022 23:16:41 -0300 Subject: [PATCH 3/4] [Fix] Lint violations --- includes/mutation/class-coupon-create.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/mutation/class-coupon-create.php b/includes/mutation/class-coupon-create.php index 556c25b38..4a60ec336 100644 --- a/includes/mutation/class-coupon-create.php +++ b/includes/mutation/class-coupon-create.php @@ -210,7 +210,7 @@ public static function mutate_and_get_payload( $input, AppContext $context, Reso $coupon->set_description( wp_filter_post_kses( $value ) ); break; case 'amount': - if ( $coupon_args['discountType'] && $coupon_args['discountType'] == 'PERCENT' ){ + if ( $coupon_args['discountType'] && 'PERCENT' === $coupon_args['discountType'] ) { $coupon->set_discount_type( 'PERCENT' ); } From 7c1a7c676ef715468ac3b3a198403549bc3498b3 Mon Sep 17 00:00:00 2001 From: victormattosvm Date: Tue, 25 Jan 2022 23:35:57 -0300 Subject: [PATCH 4/4] [Fix] Array key 'discount_type' --- includes/mutation/class-coupon-create.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/mutation/class-coupon-create.php b/includes/mutation/class-coupon-create.php index 4a60ec336..daecbcb44 100644 --- a/includes/mutation/class-coupon-create.php +++ b/includes/mutation/class-coupon-create.php @@ -210,8 +210,8 @@ public static function mutate_and_get_payload( $input, AppContext $context, Reso $coupon->set_description( wp_filter_post_kses( $value ) ); break; case 'amount': - if ( $coupon_args['discountType'] && 'PERCENT' === $coupon_args['discountType'] ) { - $coupon->set_discount_type( 'PERCENT' ); + if ( $coupon_args['discount_type'] ) { + $coupon->set_discount_type( $coupon_args['discount_type'] ); } $coupon->set_amount( $value );