save

Author: walkor

src/Client.php

@@ -95,6 +95,9 @@ public function request(string $url, array $options = []): mixed
             $this->process($address);
         } catch (Throwable $exception) {
             $this->deferError($options, $exception);
+            if ($isCoroutine) {
+                throw $exception;
+            }
             return null;
         }
         if ($isCoroutine) {

tests/RequestTest.php

@@ -61,6 +61,26 @@ public function testException()
         $this->assertTrue($errorCalled);
     }
 
+    public function testBadAddressException()
+    {
+        $successCalled = false;
+        $errorCalled = false;
+        $http = new Client();
+        $http->get(':bad_address/exception', function ($response) use (&$successCalled) {
+            $successCalled = true;
+        }, function ($exception) use (&$errorCalled) {
+            $errorCalled = true;
+        });
+        for ($i = 0; $i < 10; $i++) {
+            if ($successCalled || $errorCalled) {
+                break;
+            }
+            Timer::sleep(0.1);
+        }
+        $this->assertFalse($successCalled);
+        $this->assertTrue($errorCalled);
+    }
+
     /**
      * Test POST request with callbacks
      */
@@ -298,4 +318,24 @@ public function testSynchronousException()
 
     }
 
+    public function testSynchronousBadAddressException()
+    {
+        $throw = false;
+        try {
+            $http = new Client();
+            $options = [
+                'method' => 'POST',
+                'version' => '1.1',
+                'data' => ['key1' => 'value1', 'key2' => 'value2'],
+            ];
+            $http->request(':bad_address/exception', $options);
+        } catch (Throwable $e) {
+            $throw = true;
+            $this->assertInstanceOf(RuntimeException::class, $e);
+        }
+
+        $this->assertTrue($throw);
+
+    }
+
 }