fix: Editor loading allows deinit with weak self references

dcalhoun · dcalhoun · commit 35a0f0c14355 · 2025-10-20T15:09:56.000-04:00
Allow clean up while the editor closes.
diff --git a/WordPress/Classes/ViewRelated/NewGutenberg/NewGutenbergViewController.swift b/WordPress/Classes/ViewRelated/NewGutenberg/NewGutenbergViewController.swift
@@ -250,7 +250,8 @@ class NewGutenbergViewController: UIViewController, PostEditor, PublishingEditor
             preconditionFailure("Dependency loading should not be cancelled")
         }
 
-        self.editorLoadingTask = Task {
+        self.editorLoadingTask = Task { [weak self] in
+            guard let self else { return }
             do {
                 while case .loadingDependencies = self.editorState {
                     try await Task.sleep(nanoseconds: 1000)

Original file line number	Diff line number	Diff line change
`@@ -250,7 +250,8 @@ class NewGutenbergViewController: UIViewController, PostEditor, PublishingEditor`
`250`	`250`	`preconditionFailure("Dependency loading should not be cancelled")`
`251`	`251`	`}`
`252`	`252`
`253`		`- self.editorLoadingTask = Task {`
	`253`	`+ self.editorLoadingTask = Task { [weak self] in`
	`254`	`+ guard let self else { return }`
`254`	`255`	`do {`
`255`	`256`	`while case .loadingDependencies = self.editorState {`
`256`	`257`	`try await Task.sleep(nanoseconds: 1000)`