Skip to content

Commit 94c24d2

Browse files
authored
fix(site-explorer): skip machine ID generation for switches (dsx-ai-factory#4337)
Switches have their own `SwitchId` generation path and may not expose a system serial number. Attempting to generate a `MachineId` for them therefore produces misleading errors even when switch discovery succeeds. Skip `MachineId` generation for switches while preserving their remaining enrichment and `SwitchId` generation. ## Related issues Related to dsx-ai-factory#4277 ## Type of Change - [ ] **Add** - New feature or capability - [ ] **Change** - Changes in existing functionality - [x] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Breaking Changes - [ ] **This PR contains breaking changes** ## Testing - [ ] Unit tests added/updated - [ ] Integration tests added/updated - [x] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.) ## Additional Notes
1 parent 8fea39a commit 94c24d2

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

  • crates/site-explorer/src

‎crates/site-explorer/src/lib.rs‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,9 @@ pub fn enrich_endpoint_exploration_report(
169169
fw_config_snapshot: &FirmwareConfigSnapshot,
170170
) {
171171
if !report.is_power_shelf() {
172-
if let Err(error) = report.generate_machine_id(false) {
172+
if !report.is_switch()
173+
&& let Err(error) = report.generate_machine_id(false)
174+
{
173175
tracing::error!(%error, "Can not generate MachineId for explored endpoint");
174176
}
175177
report.model = report.model();

0 commit comments

Comments
 (0)