fix(tempo): remember direct session fallback

Author: parvahuja

src/tempo/session/client/Session.test.ts

@@ -531,69 +531,61 @@ describe('precompile client session', () => {
     },
   )
 
-  test('keeps a selected direct channel direct when a machine channel later appears', async () => {
-    const directChannelId = Channel.computeId({
-      ...descriptor,
+  test('keeps a direct fallback selected when a persisted machine route recovers', async () => {
+    const machineDescriptor = getMachineDescriptor()
+    const machineChannelId = Channel.computeId({
+      ...machineDescriptor,
+      chainId,
+      escrow: tip20ChannelEscrow,
+    })
+    const machineKey = channelKey({
       chainId,
       escrow: tip20ChannelEscrow,
+      payee: machineDescriptor.payee,
+      token: machineDescriptor.token,
     })
     const channelStore = createChannelStore()
     await channelStore.set({
       chainId,
-      channelId: directChannelId,
+      channelId: machineChannelId,
       cumulativeAmount: 100n,
       deposit: 1_000n,
-      descriptor,
+      descriptor: machineDescriptor,
       escrow: tip20ChannelEscrow,
       opened: true,
     })
+    let currentClient = createMachineClient({ routeError: true })
     const method = session({
       account,
       channelStore,
       decimals: 0,
-      getClient: () => machineClient,
+      getClient: () => currentClient,
     })
     const challenge = () =>
       makeSessionChallenge({
         methodDetails: { escrowContract: tip20ChannelEscrow, machineTokenEnabled: true },
       })
 
-    expect(
-      deserialize(await method.createCredential({ challenge: challenge(), context: {} })),
-    ).toMatchObject({
-      action: 'voucher',
-      channelId: directChannelId,
-      cumulativeAmount: '200',
-    })
-
-    const machineDescriptor = getMachineDescriptor()
-    const machineChannelId = Channel.computeId({
-      ...machineDescriptor,
-      chainId,
-      escrow: tip20ChannelEscrow,
-    })
-    const machineKey = channelKey({
-      chainId,
-      escrow: tip20ChannelEscrow,
-      payee: machineDescriptor.payee,
-      token: machineDescriptor.token,
-    })
-    await channelStore.set({
-      chainId,
-      channelId: machineChannelId,
-      cumulativeAmount: 100n,
-      deposit: 1_000n,
-      descriptor: machineDescriptor,
-      escrow: tip20ChannelEscrow,
-      opened: true,
+    const opened = deserialize(
+      await method.createCredential({ challenge: challenge(), context: {} }),
+    )
+    expect(opened).toMatchObject({
+      action: 'open',
+      descriptor: {
+        operator: descriptor.operator,
+        payee: descriptor.payee,
+        token: descriptor.token,
+      },
+      cumulativeAmount: '100',
     })
+    currentClient = machineClient
 
     expect(
       deserialize(await method.createCredential({ challenge: challenge(), context: {} })),
     ).toMatchObject({
       action: 'voucher',
-      channelId: directChannelId,
-      cumulativeAmount: '300',
+      channelId: opened.channelId,
+      cumulativeAmount: '200',
     })
     expect(await channelStore.get(machineKey)).toMatchObject({ cumulativeAmount: 100n })
   })

src/tempo/session/client/Session.ts

@@ -447,6 +447,20 @@ export function session(parameters: session.Parameters = {}) {
         // signatures succeed. Low-level Fetch opens remain staged until the
         // response acknowledges them; SessionManager owns its own boundary.
         const deferState = !!machineSession || (attempt !== undefined && plan.type === 'open')
+        const trackedSink = {
+          store: {
+            get: (key: string) => store.get(key),
+            async set(next: ChannelEntry) {
+              await store.set(next)
+              rememberRail(direct, resolved, next)
+            },
+            async delete(key: string) {
+              await store.delete(key)
+              rails.delete(direct.key)
+            },
+          },
+          notifyUpdate: sink.notifyUpdate,
+        }
         const credentialSink = deferState
           ? {
               store: {
@@ -460,7 +474,7 @@ export function session(parameters: session.Parameters = {}) {
                 pendingEntry = next
               },
             }
-          : sink
+          : trackedSink
         const feeToken = MachineTokenSession.resolveFeeToken({
           chainId: resolved.chainId,
           override: feeTokenParameter,