fix firefox un-respected padding bit

Author: rainliu

src/goodbye/mod.rs

@@ -182,7 +182,9 @@ impl Unmarshal for Goodbye {
             Bytes::new()
         };
 
-        if header.padding && raw_packet.has_remaining() {
+        if
+        /*header.padding &&*/
+        raw_packet.has_remaining() {
             raw_packet.advance(raw_packet.remaining());
         }
 

src/packet.rs

@@ -248,7 +248,7 @@ mod test {
                 143, 205, 0, 6, 65, 227, 184, 49, 118, 243, 78, 96, 42, 63, 0, 5, 12, 162, 166, 0,
                 32, 5, 200, 4, 0, 4, 0, 0,
             ]),
-            /*Bytes::from_static(&[
+            Bytes::from_static(&[
                 143, 205, 0, 9, 65, 227, 184, 49, 118, 243, 78, 96, 42, 68, 0, 17, 12, 162, 167, 1,
                 32, 17, 88, 0, 4, 0, 4, 8, 108, 0, 4, 0, 4, 12, 0, 4, 0, 4, 4, 0,
             ]),
@@ -259,7 +259,7 @@ mod test {
             Bytes::from_static(&[
                 143, 205, 0, 7, 65, 227, 184, 49, 118, 243, 78, 96, 42, 103, 0, 8, 12, 162, 169, 4,
                 32, 8, 232, 4, 0, 4, 0, 4, 4, 0, 0, 0,
-            ]),*/
+            ]),
         ];
 
         for mut test in tests {

src/payload_feedbacks/full_intra_request/mod.rs

@@ -153,7 +153,9 @@ impl Unmarshal for FullIntraRequest {
             i += 8;
         }
 
-        if h.padding && raw_packet.has_remaining() {
+        if
+        /*h.padding &&*/
+        raw_packet.has_remaining() {
             raw_packet.advance(raw_packet.remaining());
         }
 

src/payload_feedbacks/picture_loss_indication/mod.rs

@@ -123,7 +123,9 @@ impl Unmarshal for PictureLossIndication {
         let sender_ssrc = raw_packet.get_u32();
         let media_ssrc = raw_packet.get_u32();
 
-        if h.padding && raw_packet.has_remaining() {
+        if
+        /*h.padding &&*/
+        raw_packet.has_remaining() {
             raw_packet.advance(raw_packet.remaining());
         }
 

src/payload_feedbacks/receiver_estimated_maximum_bitrate/mod.rs

@@ -267,7 +267,9 @@ impl Unmarshal for ReceiverEstimatedMaximumBitrate {
             ssrcs.push(raw_packet.get_u32());
         }
 
-        if header.padding && raw_packet.has_remaining() {
+        if
+        /*header.padding &&*/
+        raw_packet.has_remaining() {
             raw_packet.advance(raw_packet.remaining());
         }
 

src/payload_feedbacks/slice_loss_indication/mod.rs

@@ -161,7 +161,9 @@ impl Unmarshal for SliceLossIndication {
             i += 4;
         }
 
-        if h.padding && raw_packet.has_remaining() {
+        if
+        /*h.padding &&*/
+        raw_packet.has_remaining() {
             raw_packet.advance(raw_packet.remaining());
         }
 

src/source_description/mod.rs

@@ -430,7 +430,9 @@ impl Unmarshal for SourceDescription {
             return Err(Error::InvalidHeader.into());
         }
 
-        if h.padding && raw_packet.has_remaining() {
+        if
+        /*h.padding &&*/
+        raw_packet.has_remaining() {
             raw_packet.advance(raw_packet.remaining());
         }
 

src/transport_feedbacks/rapid_resynchronization_request/mod.rs

@@ -126,7 +126,9 @@ impl Unmarshal for RapidResynchronizationRequest {
         let sender_ssrc = raw_packet.get_u32();
         let media_ssrc = raw_packet.get_u32();
 
-        if h.padding && raw_packet.has_remaining() {
+        if
+        /*h.padding &&*/
+        raw_packet.has_remaining() {
             raw_packet.advance(raw_packet.remaining());
         }
 

src/transport_feedbacks/transport_layer_cc/mod.rs

@@ -713,7 +713,9 @@ impl Unmarshal for TransportLayerCc {
             }
         }
 
-        if h.padding && raw_packet.has_remaining() {
+        if
+        /*h.padding &&*/
+        raw_packet.has_remaining() {
             raw_packet.advance(raw_packet.remaining());
         }
 

src/transport_feedbacks/transport_layer_nack/mod.rs

@@ -200,7 +200,9 @@ impl Unmarshal for TransportLayerNack {
             });
         }
 
-        if h.padding && raw_packet.has_remaining() {
+        if
+        /*h.padding &&*/
+        raw_packet.has_remaining() {
             raw_packet.advance(raw_packet.remaining());
         }