build(secrets): Update detect secrets configuration

germanattanasio · germanattanasio · commit 493668f6dacc · 2020-03-03T14:36:56.000-05:00
diff --git a/.secrets.baseline b/.secrets.baseline
@@ -0,0 +1,75 @@
+{
+  "exclude": {
+    "files": "package-lock.json|credentials.json",
+    "lines": null
+  },
+  "generated_at": "2020-03-03T19:34:45Z",
+  "plugins_used": [
+    {
+      "name": "AWSKeyDetector"
+    },
+    {
+      "name": "ArtifactoryDetector"
+    },
+    {
+      "base64_limit": 4.5,
+      "name": "Base64HighEntropyString"
+    },
+    {
+      "name": "BasicAuthDetector"
+    },
+    {
+      "name": "BoxDetector"
+    },
+    {
+      "name": "CloudantDetector"
+    },
+    {
+      "name": "Db2Detector"
+    },
+    {
+      "name": "GheDetector"
+    },
+    {
+      "hex_limit": 3,
+      "name": "HexHighEntropyString"
+    },
+    {
+      "name": "IbmCloudIamDetector"
+    },
+    {
+      "name": "IbmCosHmacDetector"
+    },
+    {
+      "name": "JwtTokenDetector"
+    },
+    {
+      "keyword_exclude": null,
+      "name": "KeywordDetector"
+    },
+    {
+      "name": "MailchimpDetector"
+    },
+    {
+      "name": "PrivateKeyDetector"
+    },
+    {
+      "name": "SlackDetector"
+    },
+    {
+      "name": "SoftlayerDetector"
+    },
+    {
+      "name": "StripeDetector"
+    },
+    {
+      "name": "TwilioKeyDetector"
+    }
+  ],
+  "results": {},
+  "version": "0.13.0+ibm.9.dss",
+  "word_list": {
+    "file": null,
+    "hash": null
+  }
+}
diff --git a/.utility/bintray-release.gradle b/.utility/bintray-release.gradle
@@ -30,7 +30,7 @@ bintray {
             mavenCentralSync {
                 sync = true
                 user = System.getenv('SONATYPE_USER')
-                password = System.getenv('SONATYPE_PASSWORD')
+                password = System.getenv('SONATYPE_PASSWORD') //pragma: whitelist secret
             }
         }
     }
diff --git a/.utility/generate-index-html.sh b/.utility/generate-index-html.sh
@@ -9,7 +9,7 @@ echo '<!DOCTYPE html>
     <meta http-equiv="X-UA-Compatible" content="IE=edge">
     <meta name="viewport" content="width=device-width, initial-scale=1">
     <title>IBM Watson Developer Cloud</title>
-    <link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.6/css/bootstrap.min.css" integrity="sha384-1q8mTJOASx8j1Au+a5WDVnPi2lkFfwwEAa8hDDdjZlpLegxhjVME1fgjWPGmkzs7" crossorigin="anonymous">
+    <link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.6/css/bootstrap.min.css" crossorigin="anonymous">
 </head>
 <body>
 <div class="container">
@@ -20,7 +20,7 @@ echo '<!DOCTYPE html>
     <p><a href="https://www.ibm.com/watson/developer/">Info</a>
         | <a href="https://cloud.ibm.com/developer/watson/documentation">Documentation</a>
         | <a href="https://github.com/watson-developer-cloud/java-sdk">GitHub</a>
-        | <a href="http://search.maven.org/#search%7Cga%7C1%7Cg%3A%22com.ibm.watson.developer_cloud%22%20a%3A%22java-sdk%22">Maven</a>
+        | <a href="https://search.maven.org/search?q=g:com.ibm.watson">Maven</a>
     </p>
 
     <p>Javadoc by branch/tag:</p>
diff --git a/compare-comply/src/test/resources/compare_comply/credentials.json b/compare-comply/src/test/resources/compare_comply/credentials.json
@@ -1,4 +1,4 @@
 {
   "username": "username",
   "password": "password"
-}
+}
diff --git a/discovery/src/main/java/com/ibm/watson/discovery/v1/model/CredentialDetails.java b/discovery/src/main/java/com/ibm/watson/discovery/v1/model/CredentialDetails.java
@@ -39,7 +39,7 @@ public interface CredentialType {
     /** saml. */
     String SAML = "saml";
     /** username_password. */
-    String USERNAME_PASSWORD = "username_password";
+    String USERNAME_PASSWORD = "username_password"; //pragma: whitelist secret
     /** noauth. */
     String NOAUTH = "noauth";
     /** basic. */
@@ -127,7 +127,7 @@ private Builder(CredentialDetails credentialDetails) {
       this.publicKeyId = credentialDetails.publicKeyId;
       this.privateKey = credentialDetails.privateKey;
       this.passphrase = credentialDetails.passphrase;
-      this.password = credentialDetails.password;
+      this.password = credentialDetails.password; //pragma: whitelist secret
       this.gatewayId = credentialDetails.gatewayId;
       this.sourceVersion = credentialDetails.sourceVersion;
       this.webApplicationUrl = credentialDetails.webApplicationUrl;
@@ -280,7 +280,7 @@ public Builder passphrase(String passphrase) {
      * @return the CredentialDetails builder
      */
     public Builder password(String password) {
-      this.password = password;
+      this.password = password; //pragma: whitelist secret
       return this;
     }
 
@@ -374,7 +374,7 @@ protected CredentialDetails(Builder builder) {
     publicKeyId = builder.publicKeyId;
     privateKey = builder.privateKey;
     passphrase = builder.passphrase;
-    password = builder.password;
+    password = builder.password; //pragma: whitelist secret
     gatewayId = builder.gatewayId;
     sourceVersion = builder.sourceVersion;
     webApplicationUrl = builder.webApplicationUrl;
diff --git a/discovery/src/test/java/com/ibm/watson/discovery/v1/DiscoveryServiceIT.java b/discovery/src/test/java/com/ibm/watson/discovery/v1/DiscoveryServiceIT.java
@@ -1670,7 +1670,7 @@ public void deleteUserDataIsSuccessful() {
   public void credentialsOperationsAreSuccessful() {
     String url = "https://login.salesforce.com";
     String username = "test@username.com";
-    String password = "test_password";
+    String password = "test_password"; //pragma: whitelist secret
     CredentialDetails credentialDetails = new CredentialDetails.Builder()
         .credentialType(CredentialDetails.CredentialType.USERNAME_PASSWORD)
         .url(url)
diff --git a/discovery/src/test/java/com/ibm/watson/discovery/v1/DiscoveryServiceTest.java b/discovery/src/test/java/com/ibm/watson/discovery/v1/DiscoveryServiceTest.java
@@ -1218,11 +1218,11 @@ public void deleteUserDataIsSuccessful() throws InterruptedException {
   @Test
   public void testCredentialDetails() {
     String clientId = "client_id";
-    String clientSecret = "client_secret";
+    String clientSecret = "client_secret"; //pragma: whitelist secret
     String enterpriseId = "enterprise_id";
     String organizationUrl = "organization_url";
     String passphrase = "passphrase";
-    String password = "password";
+    String password = "password"; //pragma: whitelist secret
     String privateKey = "private_key";
     String publicKeyId = "public_key_id";
     String siteCollectionPath = "site_collection_path";

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ bintray {`
`30`	`30`	`mavenCentralSync {`
`31`	`31`	`sync = true`
`32`	`32`	`user = System.getenv('SONATYPE_USER')`
`33`		`- password = System.getenv('SONATYPE_PASSWORD')`
	`33`	`+ password = System.getenv('SONATYPE_PASSWORD') //pragma: whitelist secret`
`34`	`34`	`}`
`35`	`35`	`}`
`36`	`36`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`	`1`	`{`
`2`	`2`	`"username": "username",`
`3`	`3`	`"password": "password"`
`4`		`-}`
	`4`	`+}`