[CODE-1813] Show TUI settings load failures

Co-Authored-By: Warp <agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>

Author: oz-agent

app/src/settings/init.rs

@@ -158,9 +158,8 @@ pub fn init(
         None
     };
 
-    // Always log a settings-load failure. The GUI additionally surfaces this
-    // via a banner/footer, but headless surfaces (e.g. the TUI) have no such
-    // UI, so the log is the baseline signal. Final user-facing UX is TBD.
+    // Always log a settings-load failure with its full details. User-facing
+    // surfaces may additionally present a shorter summary.
     if let Some(err) = &settings_file_error {
         match err {
             super::SettingsFileError::FileParseFailed(detail) => {

app/src/tui_export.rs

@@ -159,6 +159,7 @@ pub use crate::code_review::git_repo_model::{
 };
 pub use crate::code_review::github_repo_model::GitHubRepoModel;
 pub use crate::completer::SessionContext;
+pub use crate::global_resource_handles::GlobalResourceHandlesProvider;
 pub use crate::persistence::PersistenceWriter;
 pub use crate::prefix::longest_common_prefix;
 pub use crate::search::slash_command_menu::static_commands::commands::{
@@ -243,6 +244,7 @@ pub use crate::tui_test_support::{
     blocklist_ai_history_model_with_queries, queue_tui_permission_action,
     register_tui_input_mode_test_settings, register_tui_session_view_test_singletons,
 };
+pub use crate::user_config::{WarpConfig, WarpConfigUpdateEvent};
 pub use crate::util::image::{
     MAX_IMAGE_COUNT_FOR_QUERY, MAX_IMAGE_SIZE_BYTES, MIME_SNIFF_BYTES, ProcessImageResult,
     infer_mime_type, is_supported_image_mime_type, process_image_for_agent,

crates/warp_tui/src/session_registry.rs

@@ -10,9 +10,9 @@ use std::path::PathBuf;
 use pathfinder_geometry::vector::Vector2F;
 use warp::tui_export::{
     AIConversation, AIConversationAutoexecuteMode, AIConversationId, AmbientAgentTaskId,
-    BannerState, BlocklistAIHistoryModel, IsSharedSessionCreator, LocalTtyTerminalManager,
-    PersistenceWriter, ServerConversationToken, TerminalManagerTrait, TerminalSurfaceResult,
-    oz_run_url,
+    BannerState, BlocklistAIHistoryModel, GlobalResourceHandlesProvider, IsSharedSessionCreator,
+    LocalTtyTerminalManager, PersistenceWriter, ServerConversationToken, TerminalManagerTrait,
+    TerminalSurfaceResult, oz_run_url,
 };
 use warpui::SingletonEntity;
 use warpui_core::runtime::TuiDriverHandle;
@@ -154,14 +154,27 @@ impl TuiSessions {
         startup_directory: Option<PathBuf>,
         ctx: &mut AppContext,
     ) -> (TuiSessionId, ViewHandle<TuiTerminalSessionView>) {
-        let (exit_summary, keyboard_enhancement_supported, default_autoexecute_mode) = sessions
-            .read(ctx, |sessions, _| {
-                (
-                    sessions.exit_summary.clone(),
-                    sessions.keyboard_enhancement_supported,
-                    sessions.default_autoexecute_mode,
-                )
-            });
+        let (
+            exit_summary,
+            keyboard_enhancement_supported,
+            default_autoexecute_mode,
+            is_first_session,
+        ) = sessions.read(ctx, |sessions, _| {
+            (
+                sessions.exit_summary.clone(),
+                sessions.keyboard_enhancement_supported,
+                sessions.default_autoexecute_mode,
+                sessions.is_empty(),
+            )
+        });
+        let initial_settings_file_error = is_first_session
+            .then(|| {
+                GlobalResourceHandlesProvider::as_ref(ctx)
+                    .get()
+                    .settings_file_error
+                    .clone()
+            })
+            .flatten();
         // The manager uses this internal model for unsupported-shell state; the
         // TUI does not render a separate banner surface.
         let banner = ctx.add_model(|_| BannerState::default());
@@ -184,6 +197,7 @@ impl TuiSessions {
                         exit_summary,
                         keyboard_enhancement_supported,
                         default_autoexecute_mode,
+                        initial_settings_file_error,
                         ctx,
                     )
                 });

crates/warp_tui/src/terminal_session_view.rs

@@ -12,8 +12,8 @@ use parking_lot::FairMutex;
 use warp::appearance::AppearanceEvent;
 use warp::editor::{CodeEditorModel, CodeEditorModelEvent};
 use warp::settings::{
-    AISettings, AISettingsChangedEvent, AppEditorSettings, TuiStatuslineConfig, TuiTheme,
-    TuiThemeSettings, TuiVoiceSettings,
+    AISettings, AISettingsChangedEvent, AppEditorSettings, SettingsFileError, TuiStatuslineConfig,
+    TuiTheme, TuiThemeSettings, TuiVoiceSettings,
 };
 use warp::tui_export::{
     AIAgentActionId, AIAgentActionResultType, AIAgentContext, AIAgentExchangeId,
@@ -36,11 +36,11 @@ use warp::tui_export::{
     TerminalModel, TerminalSurface, TerminalSurfaceInit, TranscriptScope, TuiMcpAction,
     TuiMcpManager, TuiSlashCommandDataSource, TuiSlashCommandDataSourceArgs,
     TuiUpArrowHistoryItemKind, TuiUserInfoManager, TuiUserInfoManagerEvent, TuiZeroStateDataSource,
-    UserTakeOverReason, WAKEUP_THROTTLE_PERIOD, block_context_from_terminal_model,
-    build_slash_command_mixer, detect_possible_git_repo, export_conversation_markdown, log_out_tui,
-    maybe_build_ai_query_upsert_event, prepare_conversation_block_restoration,
-    record_autodetection_toggle_from_slash_command, record_saved_prompt_accepted,
-    record_static_slash_command_accepted, saved_prompt_text_for_id,
+    UserTakeOverReason, WAKEUP_THROTTLE_PERIOD, WarpConfig, WarpConfigUpdateEvent,
+    block_context_from_terminal_model, build_slash_command_mixer, detect_possible_git_repo,
+    export_conversation_markdown, log_out_tui, maybe_build_ai_query_upsert_event,
+    prepare_conversation_block_restoration, record_autodetection_toggle_from_slash_command,
+    record_saved_prompt_accepted, record_static_slash_command_accepted, saved_prompt_text_for_id,
     slash_command_selection_behavior, slash_commands, throttle,
 };
 use warp_core::channel::{Channel, ChannelState};
@@ -167,6 +167,15 @@ const RUNNING_COMMAND_DETACH_HINT: &str = "ctrl-c to return to command";
 /// Replaces the exit hint when viewing a child agent conversation.
 pub(crate) const CTRL_C_KILL_CHILD_HINT: &str = "ctrl-c again to kill child agent";
 const STARTING_SHELL_HINT: &str = "Starting shell...";
+const SETTINGS_PARSE_FAILED_HINT: &str = "Settings failed to load: invalid syntax.";
+const SETTINGS_INVALID_VALUES_HINT: &str = "Settings failed to load: invalid values.";
+
+fn settings_file_error_hint(error: &SettingsFileError) -> &'static str {
+    match error {
+        SettingsFileError::FileParseFailed(_) => SETTINGS_PARSE_FAILED_HINT,
+        SettingsFileError::InvalidSettings(_) => SETTINGS_INVALID_VALUES_HINT,
+    }
+}
 
 /// Fallback strings for the /status status menu.
 const STATUS_UNAVAILABLE: &str = "\u{2014}"; // em dash
@@ -1249,6 +1258,7 @@ impl TuiTerminalSessionView {
         exit_summary: TuiExitSummaryHandle,
         keyboard_enhancement_supported: bool,
         default_autoexecute_mode: AIConversationAutoexecuteMode,
+        initial_settings_file_error: Option<SettingsFileError>,
         ctx: &mut ViewContext<Self>,
     ) -> Self {
         let TerminalSurfaceInit {
@@ -1267,6 +1277,11 @@ impl TuiTerminalSessionView {
         ctx.subscribe_to_model(&Appearance::handle(ctx), |view, _, event, ctx| {
             view.handle_appearance_event(event, ctx);
         });
+        ctx.subscribe_to_model(&WarpConfig::handle(ctx), |view, _, event, ctx| {
+            if let WarpConfigUpdateEvent::SettingsErrors(error) = event {
+                view.show_settings_file_error(error, ctx);
+            }
+        });
 
         let terminal_surface_id: EntityId = ctx.view_id();
         let active_session =
@@ -1977,6 +1992,9 @@ impl TuiTerminalSessionView {
         if let Some(failure) = initial_zero_state_load_failure {
             view.show_zero_state_ascii_load_failure(failure, ctx);
         }
+        if let Some(error) = initial_settings_file_error {
+            view.show_settings_file_error(&error, ctx);
+        }
         view
     }
 
@@ -3002,6 +3020,10 @@ impl TuiTerminalSessionView {
         self.show_error_hint(zero_state_ascii_load_failure_hint(failure).to_owned(), ctx);
     }
 
+    fn show_settings_file_error(&mut self, error: &SettingsFileError, ctx: &mut ViewContext<Self>) {
+        self.show_error_hint(settings_file_error_hint(error).to_owned(), ctx);
+    }
+
     /// Displays success-colored feedback in the transient footer slot.
     fn show_copy_hint(&mut self, ctx: &mut ViewContext<Self>) {
         self.show_success_hint(COPY_SELECTION_HINT.to_owned(), ctx);

crates/warp_tui/src/terminal_session_view_tests.rs

@@ -10,8 +10,9 @@ use instant::Instant;
 use tempfile::TempDir;
 use warp::appearance::Appearance;
 use warp::settings::{
-    AISettings, TuiStatuslineConfig, TuiStatuslineItem, TuiTheme, TuiThemeSettings,
-    TuiUsageDisplayMode, TuiVoiceInputHoldKey, TuiVoiceSettings, TuiZeroStateObject,
+    AISettings, SettingsFileError, TuiStatuslineConfig, TuiStatuslineItem, TuiTheme,
+    TuiThemeSettings, TuiUsageDisplayMode, TuiVoiceInputHoldKey, TuiVoiceSettings,
+    TuiZeroStateObject,
 };
 use warp::terminal::model::ansi::{Handler, InputBufferValue, Mode};
 use warp::tui_export::{
@@ -21,8 +22,9 @@ use warp::tui_export::{
     Harness, InputTypeAutoDetectionSource, LLMPreferences, LinkedWorkflowData,
     LongRunningCommandControlState, PtyIntent, PtyIntentEvent, SizeInfo, SizeUpdate,
     SlashCommandDataSource as _, SlashCommandKind, TaskId, TranscriptScope, TuiMcpAction,
-    TuiMcpServerId, TuiUpArrowHistoryItemKind, UserTakeOverReason, export_conversation_markdown,
-    light_theme, register_tui_session_view_test_singletons, slash_commands,
+    TuiMcpServerId, TuiUpArrowHistoryItemKind, UserTakeOverReason, WarpConfig,
+    WarpConfigUpdateEvent, export_conversation_markdown, light_theme,
+    register_tui_session_view_test_singletons, slash_commands,
 };
 use warp_core::channel::Channel;
 use warp_core::features::FeatureFlag;
@@ -92,7 +94,10 @@ use crate::statusline_config_view::TuiStatuslineConfigEvent;
 use crate::terminal_background::TuiHostTerminalBackground;
 use crate::terminal_block::{block_content_rows, should_render_terminal_block};
 use crate::terminal_use::TuiInputTarget;
-use crate::test_fixtures::{add_test_semantic_selection, add_test_terminal_session};
+use crate::test_fixtures::{
+    add_test_semantic_selection, add_test_terminal_session,
+    add_test_terminal_session_with_settings_file_error,
+};
 use crate::transcript_view::TRANSCRIPT_BLOCK_SPACING;
 use crate::transient_hint::TransientHintTone;
 use crate::tui_builder::TuiUiBuilder;
@@ -976,6 +981,42 @@ fn zero_state_reload_failure_renders_as_an_error_footer_hint() {
     });
 }
 
+#[test]
+fn settings_reload_failure_renders_as_an_error_footer_hint() {
+    App::test((), |mut app| async move {
+        let fixture = focus_test_fixture(&mut app);
+        let (view, _) = add_focus_test_session(&mut app, &fixture, true);
+
+        app.update(|ctx| {
+            WarpConfig::handle(ctx).update(ctx, |_, ctx| {
+                ctx.emit(WarpConfigUpdateEvent::SettingsErrors(
+                    SettingsFileError::InvalidSettings(vec!["Theme".to_owned()]),
+                ));
+            });
+        });
+
+        assert_eq!(
+            view.read(&app, |view, _| {
+                view.transient_hint
+                    .current()
+                    .map(|(text, tone)| (text.to_owned(), tone))
+            }),
+            Some((
+                super::SETTINGS_INVALID_VALUES_HINT.to_owned(),
+                TransientHintTone::Error
+            ))
+        );
+
+        app.read(|ctx| {
+            let footer = view.as_ref(ctx).render_footer(ctx).finish();
+            assert_eq!(
+                render_element(footer, ctx, 120).to_lines(),
+                vec![super::SETTINGS_INVALID_VALUES_HINT.to_owned()]
+            );
+        });
+    });
+}
+
 #[test]
 fn theme_slash_command_accepts_direct_selection_and_rejects_invalid_values() {
     App::test((), |mut app| async move {
@@ -1100,6 +1141,38 @@ fn zero_state_initial_load_failure_shows_an_error_footer_hint() {
     });
 }
 
+#[test]
+fn startup_settings_parse_failure_renders_as_an_error_footer_hint() {
+    App::test((), |mut app| async move {
+        let fixture = focus_test_fixture(&mut app);
+        let view = add_focus_test_session_with_settings_file_error(
+            &mut app,
+            &fixture,
+            SettingsFileError::FileParseFailed("expected a value".to_owned()),
+        );
+
+        assert_eq!(
+            view.read(&app, |view, _| {
+                view.transient_hint
+                    .current()
+                    .map(|(text, tone)| (text.to_owned(), tone))
+            }),
+            Some((
+                super::SETTINGS_PARSE_FAILED_HINT.to_owned(),
+                TransientHintTone::Error
+            ))
+        );
+
+        app.read(|ctx| {
+            let footer = view.as_ref(ctx).render_footer(ctx).finish();
+            assert_eq!(
+                render_element(footer, ctx, 120).to_lines(),
+                vec![super::SETTINGS_PARSE_FAILED_HINT.to_owned()]
+            );
+        });
+    });
+}
+
 #[test]
 fn listening_voice_input_animates_the_input_border() {
     App::test((), |mut app| async move {
@@ -2133,6 +2206,19 @@ fn add_focus_test_session(
     (view, session_id)
 }
 
+fn add_focus_test_session_with_settings_file_error(
+    app: &mut App,
+    fixture: &FocusTestFixture,
+    error: SettingsFileError,
+) -> ViewHandle<super::TuiTerminalSessionView> {
+    let (view, manager) =
+        add_test_terminal_session_with_settings_file_error(app, fixture.window_id, Some(error));
+    app.update(|ctx| {
+        TuiSessions::register_session(&fixture.sessions, view.clone(), manager, true, ctx);
+    });
+    view
+}
+
 fn render_element(element: Box<dyn TuiElement>, ctx: &AppContext, width: u16) -> TuiBuffer {
     render_element_with_size(element, ctx, width, 1)
 }

crates/warp_tui/src/test_fixtures.rs

@@ -3,6 +3,7 @@ use std::any::Any;
 use std::sync::Arc;
 
 use parking_lot::FairMutex;
+use warp::settings::SettingsFileError;
 use warp::tui_export::{
     AIConversationAutoexecuteMode, ActiveSession, Appearance, BlocklistAIActionModel,
     BlocklistAIHistoryModel, ConversationSelection, ConversationSelectionHandle,
@@ -136,6 +137,17 @@ pub(crate) fn add_test_terminal_session(
 ) -> (
     ViewHandle<TuiTerminalSessionView>,
     ModelHandle<Box<dyn TerminalManagerTrait>>,
+) {
+    add_test_terminal_session_with_settings_file_error(app, window_id, None)
+}
+
+pub(crate) fn add_test_terminal_session_with_settings_file_error(
+    app: &mut App,
+    window_id: WindowId,
+    initial_settings_file_error: Option<SettingsFileError>,
+) -> (
+    ViewHandle<TuiTerminalSessionView>,
+    ModelHandle<Box<dyn TerminalManagerTrait>>,
 ) {
     app.update(|ctx| {
         if !ctx.has_singleton_model::<ZeroStateAnimationConfig>() {
@@ -149,6 +161,7 @@ pub(crate) fn add_test_terminal_session(
                 TuiExitSummaryHandle::default(),
                 false,
                 AIConversationAutoexecuteMode::RespectUserSettings,
+                initial_settings_file_error,
                 ctx,
             )
         });