한상우 seminar1 과제 #46
Open
한상우 seminar1 과제 #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PFCJeong
approved these changes
Oct 2, 2023
Member
PFCJeong
left a comment
PFCJeong
left a comment
There was a problem hiding this comment.
오.. 헤매셨다고 하셨는데 딱히 코멘트 드릴 것이 없을만큼 잘하셨습니다.
주석도 리뷰하는데 많은 도움이되었습니다. 수고하셨씁니다~
| interface AlbumRepository : JpaRepository<AlbumEntity, Long>{ | ||
| // 아티스트 없는 앨범들이 있을까? various artist도 artist? | ||
| @Query("SELECT a FROM albums a " + | ||
| "INNER JOIN FETCH a.artist " + |
| interface PlaylistLikeRepository : JpaRepository<PlaylistLikesEntity, Long> { | ||
| fun existsByPlaylistIdAndUserId(playlistId: Long, userId: Long): Boolean | ||
| @Transactional | ||
| @Modifying |
Member
There was a problem hiding this comment.
@Transactional 하나만 있어도 될 것 같습니다.
| import org.springframework.data.jpa.repository.Query | ||
|
|
||
| interface PlaylistGroupRepository: JpaRepository<PlaylistGroupEntity, Long> { | ||
| // 모든 그룹인지 playlists를 가지고 있는 그룹만인지 모르겠어서 일단 left join 만약 playlists가 비어있는 그룹은 제외하고 싶다면 inner join |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이리 저리 헤매다 코드도 많이 꼬인거 같고 깃도 너무 헤매서 커밋도 이상한걸 많이 해버렸네요
시간이 없어서 추가 과제는 다음에 해보겠습니다