Skip to content

Conversation

@Joris29
Copy link
Contributor

@Joris29 Joris29 commented Nov 28, 2025

Pull Request (PR) description

Drop eol jira support < 9.12.0

@bastelfreak
Copy link
Member

@SimonHoenscheid can you have a look?

@Joris29 Joris29 marked this pull request as ready for review November 28, 2025 11:28
Copy link
Member

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy of my comment from #474 because it's really about this PR: I wonder if it would it be better to put the hiera data in the module's code or as hiera data in the module, if these data are needed to make the module work.

@Joris29
Copy link
Contributor Author

Joris29 commented Dec 1, 2025

@kenyon For me it's kinda of a no go.
I'll try to keep my opinion on this simple.
While java is a requirement for jira itself i don't think this jira module should have a hard requirement on java that's why java_package is optional, a user should still have the freedom to choose whether to install it manually with the java module or with this module as a package resource.
For javahome that's something else this should not be optional and isn't really optional either because in the code this is checked: if $javahome == undef { fail('You need to specify a value for javahome') }

@kenyon
Copy link
Member

kenyon commented Dec 1, 2025

@Joris29 usually our modules have class parameters to disable management of things such as Java packages. I'm just thinking about how to make a working setup by default with minimal configuration, such as just by doing include jira. But I leave it up to you, since I'm not using this module yet (and at the rate of progress we're making, we'll probably be migrating to a cloud-hosted Jira before we get migrated to this module (and it seems that pretty much everyone will be cloud-hosted by 2029 due to EOL)).

@Joris29
Copy link
Contributor Author

Joris29 commented Dec 1, 2025

@kenyon It's also kinda present in this module because if you set a java_package it will use the package resource otherwise it won't.
About just include jira this is not really possible at the moment anyway as the default db is postgresql which requires some additional setup/config as well and i don't think you want to enforce this in the jira module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants