-
Notifications
You must be signed in to change notification settings - Fork 18
springboot jersey app v2 #90
base: master
Are you sure you want to change the base?
Conversation
This is a successor of the springboot jersey app, but does not use jersey anymore - it comes with more modern spring boot, as well as uses eureka for service discovery and load balancing.
added initial readme
Added information on Eureka server
exception is now produced, and also handled.
added application name in each of application yml files
updated build plugin settings
common module lacking main - fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments about a couple things. The primary issue is that I'm unable to run the apps as described by following the README.
| - `git clone` this repo and navigate to this dir: | ||
|
|
||
| - ```bash | ||
| git clone https://github.com/howardyoo/distributed-tracing-sample-apps/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change github link to wavefronthq.
| This is a sample java application using Springboot beachshirts (#[beachops](https://medium.com/@matthewzeier/thoughts-from-an-operations-wrangler-how-we-use-alerts-to-monitor-wavefront-71329c5e57a8)) | ||
| which makes shirts for the beach. The application is based on spring boot web using rest templates and rest annotations. | ||
| - JDK 1.8 and up | ||
| - Spring Boot 2.3.0.RC1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be updated (and the pom.xml) to a non-RC version? It looks like 2.3.0.RELEASE was released May 2020.
|
|
||
| ```bash | ||
| mvn -pl registration spring-boot:run & | ||
| mvn -pl delivery spring-boot:run & |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running the registration app works with no errors. However, this and the remaining two apps fail with:
[INFO]
[INFO] -----------------------< com.wavefront:delivery >-----------------------
[INFO] Building delivery 0.0.1-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] >>> spring-boot-maven-plugin:2.3.0.RC1:run (default-cli) > test-compile @ delivery >>>
[WARNING] The POM for com.wavefront:common:jar:0.0.1-SNAPSHOT is missing, no dependency information available
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1.006 s
[INFO] Finished at: 2021-08-30T09:10:08-06:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project delivery: Could not resolve dependencies for project com.wavefront:delivery:jar:0.0.1-SNAPSHOT: com.wavefront:common:jar:0.0.1-SNAPSHOT was not found in https://repo.spring.io/milestone during a previous attempt. This failure was cached in the local repository and resolution is not reattempted until the update interval of spring-milestones has elapsed or updates are forced -> [Help 1]
[ERROR]
| git clone https://github.com/howardyoo/distributed-tracing-sample-apps/ | ||
| cd ./distributed-tracing-sample-apps/3D-microservices-observability/springboot-jersey-app-2 | ||
| ``` | ||
| - Run `mvn clean compile` from the root directory of the project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running the command was successful, but gave this warning at the beginning:
[INFO] Scanning for projects...
[WARNING]
[WARNING] Some problems were encountered while building the effective model for com.wavefront:common:jar:0.0.1-SNAPSHOT
[WARNING] 'dependencies.dependency.version' for org.springframework.cloud:spring-cloud-starter-eureka-server:jar is either LATEST or RELEASE (both of them are being deprecated) @ com.wavefront:springboot-jersey-app-2:0.0.1-SNAPSHOT, /Users/oppegard/workspace/wf/distributed-tracing-sample-apps/3D-microservices-observability/springboot-jersey-app-2/pom.xml, line 88, column 13
[WARNING]
[WARNING] Some problems were encountered while building the effective model for com.wavefront:springboot-jersey-app-2:pom:0.0.1-SNAPSHOT
[WARNING] 'dependencies.dependency.version' for org.springframework.cloud:spring-cloud-starter-eureka-server:jar is either LATEST or RELEASE (both of them are being deprecated) @ line 88, column 13
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]
Can you take a look and see if this is fixable?
this project is an extension of jersey app v1 with having auto-service discovery using Springboot Eureka, also make sit easier to run all the services in a single run - using intelliJ services. Also has loadgen.sh that can invoke loads.