v3: fix borrowed array map and pointer sorting (#28242)

Author: medvednikov

vlib/v/tests/builtin_arrays/array_map_ref_it_test.v

@@ -23,13 +23,20 @@ fn test_array_map_ref_it_after_filter_keeps_struct_fields() {
 		id:     2
 		square: false
 	}
+	shapes.rectangles << MapRefRectangle{
+		id:     3
+		square: true
+	}
 
 	squares := shapes.get_squares()
 	rendered := '${squares}'
 
-	assert squares.len == 1
+	assert squares.len == 2
+	assert voidptr(squares[0]) != voidptr(squares[1])
 	assert squares[0].id == 1
 	assert squares[0].square
+	assert squares[1].id == 3
+	assert squares[1].square
 	assert rendered.contains('id: 1')
 	assert rendered.contains('square: true')
 }

vlib/v/tests/builtin_arrays/sorting_compare_fn_with_mut_reference_test.v

@@ -38,3 +38,57 @@ fn test_sort_compare_fn_with_mut_ref_param() {
 	assert t.items[1] == &Thing{2, 4, 3}
 	assert t.items[2] == &Thing{5, 7, 6}
 }
+
+fn compare_thing_slots(a &&Thing, b &&Thing) int {
+	return (*a).a - (*b).a
+}
+
+fn test_sort_compare_fn_with_pointer_slots() {
+	mut items := [&Thing{a: 3}, &Thing{a: 1}, &Thing{a: 2}]
+	items.sort_with_compare(compare_thing_slots)
+	assert items.map(it.a) == [1, 2, 3]
+}
+
+fn compare_thing_values(a &Thing, b &Thing) int {
+	return a.a - b.a
+}
+
+fn test_sort_compare_local_fn_with_pointer_values() {
+	mut items := [&Thing{a: 3}, &Thing{a: 1}, &Thing{a: 2}]
+	compare := compare_thing_values
+	items.sort_with_compare(compare)
+	assert items.map(it.a) == [1, 2, 3]
+}
+
+fn get_thing_comparator() fn (&Thing, &Thing) int {
+	return compare_thing_values
+}
+
+fn test_sort_compare_call_fn_with_pointer_values() {
+	mut items := [&Thing{a: 3}, &Thing{a: 1}, &Thing{a: 2}]
+	items.sort_with_compare(get_thing_comparator())
+	assert items.map(it.a) == [1, 2, 3]
+}
+
+struct ThingComparators {
+	@[required]
+	compare fn (&Thing, &Thing) int
+}
+
+fn test_sort_compare_selector_fn_with_pointer_values() {
+	mut items := [&Thing{a: 3}, &Thing{a: 1}, &Thing{a: 2}]
+	comparators := ThingComparators{
+		compare: compare_thing_values
+	}
+	items.sort_with_compare(comparators.compare)
+	assert items.map(it.a) == [1, 2, 3]
+}
+
+type ThingCompare = fn (&Thing, &Thing) int
+
+fn test_sort_compare_alias_fn_with_pointer_values() {
+	mut items := [&Thing{a: 3}, &Thing{a: 1}, &Thing{a: 2}]
+	compare := ThingCompare(compare_thing_values)
+	items.sort_with_compare(compare)
+	assert items.map(it.a) == [1, 2, 3]
+}