Merge pull request #241 from vinta/fix/spacing-rules

Fix/spacing rules

Author: vinta

.claude/TODO.md

@@ -15,31 +15,71 @@
 
 - [x] Replace `tabs` permission with `activeTab` (removes "Read browsing history" warning)
 - [x] Implement dynamic content script registration with chrome.scripting API
-- [x] Optimize pangu.js loading with on-demand injection
+- [x] Optimize `pangu.js` loading with on-demand injection
+- [x] Skip auto spacing if there is no CJK content in webpages
 
 ### Match Pattern Implementation
 
 - [x] Implement blacklist/whitelist with Chrome match pattern validation
 - [x] Use Chrome's `excludeMatches` API for efficient blacklist handling
 - [x] Add match pattern validation with helpful error messages
 
+### Regex Pattern Fixes
+
+- [x] Fixed `AN_LEFT_BRACKET` pattern to prevent adding spaces in function calls like `a.getB()`
+  - Added negative lookbehind `(?<!\\.[A-Za-z0-9]*)` to exclude patterns after dots
+- [x] Fixed pipe character `|` handling - removed from operator patterns (#194)
+- [x] Fixed filesystem path patterns to support special characters like `@`, `+`, dots (#209, #218, #219)
+  - Enhanced pattern to match paths like `/node_modules/@babel/core`
+- [x] Fixed HTML tag spacing - tags no longer get spaces inside them (#164)
+  - Implemented placeholder system to protect HTML tags during processing
+  - Attribute values still get processed for spacing
+- [x] Fixed input field auto-spacing (#158)
+  - Added `input` to `ignoredTags` regex in browser implementation
+  - Prevents spacing in form fields, login/registration forms
+- [x] Fixed slash pattern conflict with filesystem paths
+  - Removed `/` from `CJK_ANS` pattern to prevent spacing in patterns like `陳上進/vinta`
+  - Made filesystem path pattern more specific to avoid false matches
+- [x] Improved filesystem path pattern to be less aggressive
+  - Changed from matching any `/something` to only known system directories
+  - Removed the `FIX_NAME_SLASH` workaround as it's no longer needed
+  - Pattern now only matches paths starting with system dirs like `/home`, `/usr`, `/etc`, or `/node_modules`
+
 ## In Progress
 
-- [ ] None
+- [ ] None currently active
 
 ## Next Steps
 
-### High Priority
+### High Priority - Unfixed Issues
 
-- [ ] Generate different size icons from `icon_1500.svg`
-- [ ] Add a button for "Add this url to blacklist" in popup page or context menu
+- [ ] Fix issue #173 - Full-width curved quotes shouldn't have spaces
+  - Full-width quotation marks (「」『』) are being incorrectly spaced
+  - These are punctuation marks in CJK languages and shouldn't be separated
+
+### Medium Priority - Unfixed Issues
+
+- [ ] Fix issue #201 - Spaces inserted between image-separated text
+  - When images are used as separators, unwanted spaces are added
+- [ ] Fix issue #207 - Breaking Bilibili upload page layout
+  - Auto-spacing interferes with specific website functionality
+  - May need site-specific rules or better element detection
 
-### Medium Priority
+### Low Priority - Unfixed Issues
 
-- [x] No need to perform spacing if there is no CJK in webpages
-  - Implemented pageHasCJK() detection in BrowserPangu class
-  - Added watchForCJKContent() for dynamic content monitoring
-  - Saves processing time on pages without CJK content
+- [ ] Fix issue #169 - YouTube title persistence bug
+  - Changes to YouTube titles don't persist
+  - May be related to YouTube's dynamic content updates
+- [ ] Fix issue #216 - Add support for skipping Markdown syntax
+  - Markdown formatting (like `**bold**`, `_italic_`) gets broken by spacing
+  - Need to protect Markdown syntax during processing
+- [ ] Fix issue #161 - Markdown syntax support
+  - Similar to #216, need comprehensive Markdown protection
+
+### Feature Enhancements
+
+- [ ] Generate different size icons from `icon_1500.svg`
+- [ ] Add a button for "Add this url to blacklist" in popup page or context menu
 - [ ] Improve `autoSpacingPage()` performance, especially with a large DOM tree
   - See @.claude/researches/performance-optimization.md
 - [ ] Add instructions in options page for enabling experimental CSS `text-autospace`

README.md

@@ -22,6 +22,7 @@
 
 - Community support:
 
+  - [Paranoid Text Spacing](https://tools.1chooo.com/paranoid-text-spacing)
   - [盤古之白 - 文案排版轉換](https://pangu.serko.dev/)
 
 ### For Developers
@@ -57,7 +58,7 @@ Learn more on [npm](https://www.npmjs.com/package/pangu).
 ```html
 <script src="pangu/dist/browser/pangu.umd.js"></script>
 <script>
-  const text = pangu.spacing('當你凝視著bug，bug也凝視著你');
+  const text = pangu.spacingText('當你凝視著bug，bug也凝視著你');
   // text = '當你凝視著 bug，bug 也凝視著你'
 
   pangu.spacingElementById('main');
@@ -85,7 +86,7 @@ import pangu from 'pangu';
 // or
 const pangu = require('pangu');
 
-const text = pangu.spacing('與PM戰鬥的人，應當小心自己不要成為PM');
+const text = pangu.spacingText('與PM戰鬥的人，應當小心自己不要成為PM');
 // text = '與 PM 戰鬥的人，應當小心自己不要成為 PM'
 
 const content = await pangu.spacingFile('/path/to/text.txt');

browser_extensions/chrome/dist/content-script.js

@@ -3,7 +3,15 @@
   const DEFAULT_SETTINGS = {
     spacing_mode: "spacing_when_load",
     filter_mode: "blacklist",
-    blacklist: ["*://docs.google.com/*", "*://gist.github.com/*", "*://github.com/*/blob/*", "*://github.com/*/commit/*", "*://github.com/*/pull/*"],
+    blacklist: [
+      "https://docs.google.com/*",
+      "https://gist.github.com/*",
+      "https://github.com/*/blob/*",
+      "https://github.com/*/commit/*",
+      "https://github.com/*/pull/*",
+      "https://github.com/vinta/pangu.js/issues*",
+      "https://www.netflix.com/*"
+    ],
     whitelist: [],
     is_mute_sound_effects: false,
     is_enable_detect_cjk: false

browser_extensions/chrome/dist/utils/settings.js

@@ -1,7 +1,15 @@
 const DEFAULT_SETTINGS = {
   spacing_mode: "spacing_when_load",
   filter_mode: "blacklist",
-  blacklist: ["*://docs.google.com/*", "*://gist.github.com/*", "*://github.com/*/blob/*", "*://github.com/*/commit/*", "*://github.com/*/pull/*"],
+  blacklist: [
+    "https://docs.google.com/*",
+    "https://gist.github.com/*",
+    "https://github.com/*/blob/*",
+    "https://github.com/*/commit/*",
+    "https://github.com/*/pull/*",
+    "https://github.com/vinta/pangu.js/issues*",
+    "https://www.netflix.com/*"
+  ],
   whitelist: [],
   is_mute_sound_effects: false,
   is_enable_detect_cjk: false

browser_extensions/chrome/src/utils/settings.ts

@@ -3,7 +3,15 @@ import type { Settings } from './types';
 export const DEFAULT_SETTINGS: Settings = {
   spacing_mode: 'spacing_when_load',
   filter_mode: 'blacklist',
-  blacklist: ['*://docs.google.com/*', '*://gist.github.com/*', '*://github.com/*/blob/*', '*://github.com/*/commit/*', '*://github.com/*/pull/*'],
+  blacklist: [
+    'https://docs.google.com/*',
+    'https://gist.github.com/*',
+    'https://github.com/*/blob/*',
+    'https://github.com/*/commit/*',
+    'https://github.com/*/pull/*',
+    'https://github.com/vinta/pangu.js/issues*',
+    'https://www.netflix.com/*',
+  ],
   whitelist: [],
   is_mute_sound_effects: false,
   is_enable_detect_cjk: false,