Skip to content

Commit 5dddfac

Browse files
committed
fix(zakura): align root coverage test after rebase
1 parent 3a27ed3 commit 5dddfac

2 files changed

Lines changed: 8 additions & 10 deletions

File tree

‎zebra-state/src/service.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1517,7 +1517,7 @@ where
15171517
finalized_state::serve_block_roots(db, height..=height)
15181518
.into_iter()
15191519
.next()
1520-
// If the height is in the chain, serve the roots from the chain
1520+
// If the height is in the chain, serve the roots from the chain
15211521
} else if let Some(chain) = chain
15221522
.as_ref()
15231523
.map(|chain| chain.as_ref())

‎zebrad/src/commands/start.rs‎

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2183,7 +2183,7 @@ mod zakura_header_sync_driver_tests {
21832183
}
21842184

21852185
#[test]
2186-
fn served_header_tree_aux_roots_use_aligned_prefix() {
2186+
fn served_header_tree_aux_roots_require_complete_coverage() {
21872187
let start = block::Height(10);
21882188
let header_heights = [
21892189
block::Height(10),
@@ -2193,21 +2193,19 @@ mod zakura_header_sync_driver_tests {
21932193
];
21942194
let roots = [root_at(block::Height(10)), root_at(block::Height(11))];
21952195

2196-
assert_eq!(
2197-
tree_aux_roots_for_served_header_range(start, header_heights, &roots),
2198-
Ok(roots.to_vec()),
2199-
"partial root coverage is served as the aligned prefix"
2196+
assert!(
2197+
tree_aux_roots_for_served_header_range(start, header_heights, &roots).is_err(),
2198+
"partial root coverage is reported before serving rootless headers"
22002199
);
22012200

22022201
let roots_with_gap = [
22032202
root_at(block::Height(10)),
22042203
root_at(block::Height(12)),
22052204
root_at(block::Height(13)),
22062205
];
2207-
assert_eq!(
2208-
tree_aux_roots_for_served_header_range(start, header_heights, &roots_with_gap),
2209-
Ok(vec![root_at(block::Height(10))]),
2210-
"root gaps are served up to the aligned prefix"
2206+
assert!(
2207+
tree_aux_roots_for_served_header_range(start, header_heights, &roots_with_gap).is_err(),
2208+
"root gaps are reported before serving rootless headers"
22112209
);
22122210

22132211
let complete_roots = [

0 commit comments

Comments
 (0)