Repository navigation
Commit 9036957
committed
docs: cite the documented all-zero key B instead of inferring it
The previous round stated the key B premise as an inference and closed the
paragraph with "No key B is published, derived, or claimed anywhere in the
guide." That sentence is false. BambuLabRfid.md line 70 documents the sector
trailer as
| 10 (BB) | 6 | RAW Bin | B-Key (always `00 00 00 00 00 00` for Bambu tags) |
and the guide's examples/exampleDump.bin carries six zero bytes at offset 10 of
all 16 trailers. This strengthens the change rather than weakening it: the
derived key A is a non-zero HKDF output, so it is definitively not the tag's key
B, and the 80 -> 16 arithmetic is established rather than conditional.
Lead the code comment with the two reasons that do not depend on what upstream
happens to publish: the tag's key B is all zeros so no derived key can match it,
and key A alone reads every block this plugin parses so any key B entry is waste
regardless. The old wording led with the absence of a published key B
derivation, which a reader who later finds BambuLabRfid.md could take as
refuted and use to justify restoring the key B assignment.
Drop the CHANGELOG's "were a tag's key B in fact equal to its key A" hedge for
the same reason. "Publishes that derivation alone" is narrower and stays.
No behaviour change: .text 3,364, .rodata 7,596, .fal 21,548 and the 18-symbol
import list are identical before and after.1 parent f72404b commit 9036957
2 files changed
Lines changed: 13 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
58 | 57 | | |
59 | 58 | | |
60 | 59 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
267 | 267 | | |
268 | 268 | | |
269 | 269 | | |
270 | | - | |
271 | | - | |
272 | | - | |
273 | | - | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
274 | 275 | | |
275 | 276 | | |
276 | 277 | | |
| |||
0 commit comments