Skip to content

Commit 82f2810

Browse files
JayGhiyagitbutler-client
authored andcommitted
fix: test assertions
Update dependency to use GitHub source instead of local directory Upgrade unoplat-code-confluence-commons from v0.31.2 to v0.32.0 Adjust test assertions for data model detection to reflect current implementation, adding a note about BaseModel detection limitations
1 parent 0ff7be8 commit 82f2810

2 files changed

Lines changed: 7 additions & 17 deletions

File tree

unoplat-code-confluence-ingestion/code-confluence-flow-bridge/tests/parser/test_generic_codebase_parser.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -381,6 +381,8 @@ async def test_parser_inserts_nodes(
381381
assert api_has_data_model is False, "api_client.py should be marked as has_data_model=False"
382382

383383
# 12. Count total dataclass vs non-dataclass files
384+
# NOTE: Currently only detects @dataclass decorators, not Pydantic BaseModel inheritance
385+
# settings.py uses BaseModel and is NOT detected as a data model (expected behavior for now)
384386
result, _ = neo4j_client.cypher_query(
385387
"MATCH (f:CodeConfluenceFile) RETURN f.has_data_model, COUNT(f) as count"
386388
)
@@ -393,8 +395,8 @@ async def test_parser_inserts_nodes(
393395
else:
394396
non_dataclass_count = row[1]
395397

396-
assert dataclass_count == 2, f"Expected 1 dataclass file, got {dataclass_count}"
397-
assert non_dataclass_count == 4, f"Expected 5 non-dataclass files, got {non_dataclass_count}" # __main__.py, api_client.py, settings.py, generator.py, helpers.py
398+
assert dataclass_count == 1, f"Expected 1 dataclass file (user_model.py), got {dataclass_count}"
399+
assert non_dataclass_count == 5, f"Expected 5 non-dataclass files (__main__.py, api_client.py, settings.py, generator.py, helpers.py), got {non_dataclass_count}"
398400

399401
logger.info(f"Data model detection test passed: {dataclass_count} dataclass files, {non_dataclass_count} regular files")
400402
logger.info(

unoplat-code-confluence-ingestion/code-confluence-flow-bridge/uv.lock

Lines changed: 3 additions & 15 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)