Skip to content

Conversation

@pedberg-icu
Copy link
Contributor

@pedberg-icu pedberg-icu commented Nov 24, 2025

CLDR-19054

  • This PR completes the ticket.

Added display names for key hc new types c12, c24, deriving them from the existing types h11,h12,h23,h24 by deleting the parenthesized ranges.

  • Added "core" versions if the locale had them for h11,h12,h23,h24 and used same draft status as the existing h11,h12,h23,h24.
  • Did not do this for locale to since the c12, c24 were not derivable in the same way. In that locale the existing h11,h12,h23,h24 are unconfirmed anyway.
  • Made some spot fixes to the existing h11,h12,h23,h24 in certain locales:
    • ak: h12, fixed missing final paren
    • as: h23/core was completely bogus, fixed to be like other cores
    • ccp: h23, fixed missing space
    • kxv: h12, fixed spaces around range
  • For several locales as, ne, ti the "core" value is repeated; did not change but will file a ticket.

Also made other necessary updates:

  • Removed "deprecated" status for c12, c24 in common/bcp47/calendar.xml
  • In unit test TestCoverageLevel.TestCoverageCompleteness allowed display names for c12, c24 to be at comprehensive, at least for now.

ALLOW_MANY_COMMITS=true

@pedberg-icu pedberg-icu self-assigned this Nov 24, 2025
@pedberg-icu pedberg-icu changed the title CLDR-19054 derived display names for c12,c24; undeprecate them for bcp47; allow at coverage 100 CLDR-19054 derived display names for c12,c24; undeprecate for bcp47; allow at coverage 100 Nov 24, 2025
@sffc
Copy link
Member

sffc commented Dec 3, 2025

It's weird how some locales have "core" and others don't, but that's a pre-existing issue.

@AEApple
Copy link
Contributor

AEApple commented Dec 3, 2025

It's weird how some locales have "core" and others don't, but that's a pre-existing issue.

Many languages are at basic and not all languages have language specialists who contribute to them every year so we do sometimes see locales drop in coverage over time.

Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spot-checked the XML. GitHub is acting up and I wasn't able to load the Java file.

<type key="hc" type="h12" scope="core">১২ (১–১২) ১২ (১–১২)</type>
<type key="hc" type="h23">২৪ ঘণ্টীয়া প্ৰণালী (০–২৩)</type>
<type key="hc" type="h23" scope="core">24 (0–23) Hour Cycle (12 vs 24) others… ২৪ (০–২৩) …অন্য ঘণ্টীয়া প্ৰণালী(১২ বনাম ২৪): ২৪ (০–২৩) ৩ (০–২৩)</type>
<type key="hc" type="h23" scope="core">২৪ (০–২৩) ২৪ (০–২৩)</type>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<type key="hc" type="h23" scope="core">২৪ (০–২৩) ২৪ (০–২৩)</type>
<type key="hc" type="h23" scope="core">২৪ (০–২৩)</type>

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had filed a separate ticket to fix several instances like this: https://unicode-org.atlassian.net/browse/CLDR-19134

@pedberg-icu pedberg-icu merged commit 055d248 into unicode-org:main Dec 4, 2025
15 checks passed
@pedberg-icu pedberg-icu deleted the CLDR-19054-add-display-names-for-c12-c24 branch December 4, 2025 17:47
pedberg-icu added a commit to pedberg-icu/cldr that referenced this pull request Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants