Fix and modernize CI

Bump actions/checkout (v2 -> v7) and actions/setup-go (v5 -> v7), which drops the deprecated actions/cache@v1 that was auto-failing every run. Run checkout before setup-go and set cache-dependency-path so setup-go module caching finds go.sum (this repo checks out into $GOPATH/src). Remove the dead glide actions/cache step (no glide.lock or vendor dir in the repo).

Exclude the stdlib internal/synctest package from check_no_test_deps: Go 1.25+ pulls it into production deps via sync, and its name trips the test/mock grep -- the same false positive already handled for internal/testlog.

Stabilize TestIdleSweepIgnoresConnectionsWithCalls: give each ping attempt a fresh context instead of reusing a single 1s context across a 10s retry loop, which expired mid-loop and failed every remaining ping on a slow host.

Stabilize TestRelayRaceCompletionAndTimeout under the coverage-instrumented run: its deliberate timeout/completion race can recycle a client id that collides with a still-active exchange, so allowlist the resulting "Couldn't register exchange." and duplicate-id "Protocol error." logs, matching the race artifacts the test already tolerates.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: justinhwang

.github/workflows/tests.yaml

@@ -28,23 +28,18 @@ jobs:
           LINT: "yes"
 
     steps:
-    - name: Setup Go
-      uses: actions/setup-go@v5
-      with:
-        go-version: ${{ matrix.go }}
-
     - name: Checkout code
-      uses: actions/checkout@v2
+      uses: actions/checkout@v7
       with:
         path: ${{ env.GOPATH }}/src/github.com/${{ github.repository }}
 
-    - name: Load cache
-      uses: actions/cache@v1
+    - name: Setup Go
+      uses: actions/setup-go@v7
       with:
-        path: ~/.glide/cache
-        key: ${{ runner.os }}-go-${{ hashFiles('**/glide.lock') }}
-        restore-keys: |
-          ${{ runner.os }}-go-
+        go-version: ${{ matrix.go }}
+        # Code is checked out into $GOPATH/src (above), not the workspace root,
+        # so point setup-go's module cache at the real go.sum location.
+        cache-dependency-path: '**/go.sum'
 
     - name: Install CI
       run: make install_ci

Makefile

@@ -85,7 +85,7 @@ test_relay_frame_leaks:
 	PATH=$(BIN):$$PATH go test -parallel=4 $(TEST_ARG) relay_test.go
 
 check_no_test_deps:
-	! go list -json $(PROD_PKGS) | jq -r '.Deps | select ((. | length) > 0) | .[]' | grep -e test -e mock | grep -v '^internal/testlog'
+	! go list -json $(PROD_PKGS) | jq -r '.Deps | select ((. | length) > 0) | .[]' | grep -e test -e mock | grep -vE '^internal/(testlog|synctest)'
 
 benchmark: clean setup $(BIN)/thrift
 	echo Running benchmarks:

idle_sweep_test.go

@@ -319,9 +319,6 @@ func TestIdleSweepMisconfiguration(t *testing.T) {
 }
 
 func TestIdleSweepIgnoresConnectionsWithCalls(t *testing.T) {
-	ctx, cancel := NewContext(time.Second)
-	defer cancel()
-
 	clientTicker := testutils.NewFakeTicker()
 	clock := testutils.NewStubClock(time.Now())
 
@@ -351,6 +348,11 @@ func TestIdleSweepIgnoresConnectionsWithCalls(t *testing.T) {
 		// Client 1 will just ping, so we create a connection that should be closed.
 		c1 := ts.NewClient(clientOpts)
 		require.True(t, testutils.WaitFor(10*time.Second, func() bool {
+			// Use a fresh, timeout-scaled context per attempt. A single short
+			// context shared across this retry loop would expire partway through
+			// and fail every remaining ping on a slow (e.g. CI) host.
+			ctx, cancel := NewContext(testutils.Timeout(time.Second))
+			defer cancel()
 			return c1.Ping(ctx, ts.HostPort()) == nil
 		}), "Ping failed")
 

relay_test.go

@@ -1189,6 +1189,11 @@ func TestRelayRaceCompletionAndTimeout(t *testing.T) {
 		AddLogFilter("Too many tombstones, deleting relay item immediately.", numCalls).
 		AddLogFilter("Received a frame without a RelayItem.", numCalls).
 		AddLogFilter("Attempted to create new mex after mexset shutdown.", numCalls).
+		// A timed-out call can have its client id recycled and collide with an
+		// exchange the server still treats as active, surfacing as a duplicate-id
+		// protocol error and a failed exchange registration.
+		AddLogFilter("Couldn't register exchange.", numCalls).
+		AddLogFilter("Protocol error.", numCalls, "error", "inbound request is already active").
 		SetRelayOnly()
 	testutils.WithTestServer(t, opts, func(t testing.TB, ts *testutils.TestServer) {
 		testutils.RegisterEcho(ts.Server(), nil)