Remove remaining Flipflop tests

Author: nomadicoder

spec/controllers/catalog_controller_spec.rb

@@ -25,7 +25,7 @@
     end
 
     before do
-      allow(Flipflop).to receive(:bot_challenge?).and_return(true)
+      allow(controller).to receive(:bot_challenge?).and_return(true)
     end
 
     it "returns the bot challenge before search session tracking" do
@@ -36,34 +36,6 @@
       expect(response).to have_http_status(:forbidden)
     end
 
-    context "with an authenticated user" do
-      let(:user) { FactoryBot.create(:user) }
-
-      before do
-        sign_in user
-      end
-
-      it "preserves normal catalog access" do
-        get :index, params: { q: "authenticated user characterization" }
-
-        expect(response).to have_http_status(:ok)
-      end
-    end
-
-    context "with a signed-in guest user" do
-      let(:guest_user) { FactoryBot.create(:user, guest: true) }
-
-      before do
-        sign_in guest_user
-      end
-
-      it "continues to require the bot challenge" do
-        get :index, params: { q: "guest user characterization" }
-
-        expect(response).to have_http_status(:forbidden)
-      end
-    end
-
     context "with a valid bot challenge pass" do
       before do
         challenge_controller =
@@ -119,18 +91,6 @@
       end
     end
 
-    context "when the Flipflop challenge flag is disabled" do
-      before do
-        allow(Flipflop).to receive(:bot_challenge?).and_return(false)
-      end
-
-      it "preserves normal catalog access" do
-        get :index, params: { q: "disabled challenge characterization" }
-
-        expect(response).to have_http_status(:ok)
-      end
-    end
-
     context "when the global bot challenge configuration is disabled" do
       before do
         BotChallengePage::BotChallengePageController

spec/controllers/primo_central_controller_spec.rb

@@ -32,7 +32,7 @@
 
     before do
       allow(helpers).to receive(:current_page?).and_return(false)
-      allow(Flipflop).to receive(:bot_challenge?).and_return(true)
+      allow(controller).to receive(:bot_challenge?).and_return(true)
     end
 
     it "returns the article bot challenge before search tracking and recaptcha" do