test: tighten ky things route coverage

Author: saitejabandaru-in

tests/routes/things/create.test.ts

@@ -17,7 +17,13 @@ test("create a thing", async () => {
 
   const data = await ky
     .get("things/list")
-    .json<{ things: { name: string; description: string }[] }>()
+    .json<{ things: { thing_id: string; name: string; description: string }[] }>()
 
-  expect(data.things).toHaveLength(1)
+  expect(data.things).toEqual([
+    {
+      thing_id: "0",
+      name: "Thing1",
+      description: "Thing1 Description",
+    },
+  ])
 })

tests/routes/things/delete.test.ts

@@ -40,3 +40,34 @@ test("delete a thing", async () => {
 
   expect(listAfter.things).toHaveLength(0)
 })
+
+test("delete is a no-op for unknown thing ids", async () => {
+  const { ky } = await getTestServer()
+
+  await ky.post("things/create", {
+    json: {
+      name: "Thing1",
+      description: "Thing1 Description",
+    },
+  })
+
+  const deleteResponse = await ky
+    .post("things/delete", {
+      body: new URLSearchParams({ thing_id: "missing" }),
+    })
+    .json<{ ok: boolean }>()
+
+  expect(deleteResponse).toEqual({ ok: true })
+
+  const data = await ky.get("things/list").json<{
+    things: { thing_id: string; name: string; description: string }[]
+  }>()
+
+  expect(data.things).toEqual([
+    {
+      thing_id: "0",
+      name: "Thing1",
+      description: "Thing1 Description",
+    },
+  ])
+})

tests/routes/things/list.test.ts

@@ -0,0 +1,46 @@
+import { expect, test } from "bun:test"
+import { getTestServer } from "tests/fixtures/get-test-server"
+
+test("list starts empty", async () => {
+  const { ky } = await getTestServer()
+
+  const data = await ky.get("things/list").json<{
+    things: { thing_id: string; name: string; description: string }[]
+  }>()
+
+  expect(data.things).toEqual([])
+})
+
+test("list preserves insertion order and generated ids", async () => {
+  const { ky } = await getTestServer()
+
+  await ky.post("things/create", {
+    json: {
+      name: "Thing1",
+      description: "Thing1 Description",
+    },
+  })
+  await ky.post("things/create", {
+    json: {
+      name: "Thing2",
+      description: "Thing2 Description",
+    },
+  })
+
+  const data = await ky.get("things/list").json<{
+    things: { thing_id: string; name: string; description: string }[]
+  }>()
+
+  expect(data.things).toEqual([
+    {
+      thing_id: "0",
+      name: "Thing1",
+      description: "Thing1 Description",
+    },
+    {
+      thing_id: "1",
+      name: "Thing2",
+      description: "Thing2 Description",
+    },
+  ])
+})