Bumping min required cxx standard to 17 (#100)

oandreeva-nv · web-flow · commit 39d7a0cde2ef · 2024-01-11T12:01:24.000-08:00
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -28,6 +28,9 @@ cmake_minimum_required(VERSION 3.17)
 
 project(tritontensorflowbackend LANGUAGES C CXX)
 
+# Use C++17 standard as Triton's minimum required.
+set(TRITON_MIN_CXX_STANDARD 17 CACHE STRING "The minimum C++ standard which features are requested to build this target.")
+
 #
 # Options
 #
@@ -193,7 +196,7 @@ if (NOT ${TRITON_TENSORFLOW_DOCKER_BUILD})
   )
 endif() # !TRITON_TENSORFLOW_DOCKER_BUILD
 
-target_compile_features(triton-tensorflow-backend PRIVATE cxx_std_11)
+target_compile_features(triton-tensorflow-backend PRIVATE cxx_std_${TRITON_MIN_CXX_STANDARD})
 target_compile_options(
   triton-tensorflow-backend PRIVATE
   $<$<OR:$<CXX_COMPILER_ID:Clang>,$<CXX_COMPILER_ID:AppleClang>,$<CXX_COMPILER_ID:GNU>>:

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,9 @@ cmake_minimum_required(VERSION 3.17)`
`28`	`28`
`29`	`29`	`project(tritontensorflowbackend LANGUAGES C CXX)`
`30`	`30`
	`31`	`+# Use C++17 standard as Triton's minimum required.`
	`32`	`+set(TRITON_MIN_CXX_STANDARD 17 CACHE STRING "The minimum C++ standard which features are requested to build this target.")`
	`33`	`+`
`31`	`34`	`#`
`32`	`35`	`# Options`
`33`	`36`	`#`
`@@ -193,7 +196,7 @@ if (NOT ${TRITON_TENSORFLOW_DOCKER_BUILD})`
`193`	`196`	`)`
`194`	`197`	`endif() # !TRITON_TENSORFLOW_DOCKER_BUILD`
`195`	`198`
`196`		`-target_compile_features(triton-tensorflow-backend PRIVATE cxx_std_11)`
	`199`	`+target_compile_features(triton-tensorflow-backend PRIVATE cxx_std_${TRITON_MIN_CXX_STANDARD})`
`197`	`200`	`target_compile_options(`
`198`	`201`	`triton-tensorflow-backend PRIVATE`
`199`	`202`	`$<$<OR:$<CXX_COMPILER_ID:Clang>,$<CXX_COMPILER_ID:AppleClang>,$<CXX_COMPILER_ID:GNU>>:`