improve coverage

Author: kvz

src/test/java/com/transloadit/sdk/SignatureProviderTest.java

@@ -84,6 +84,17 @@ void toPayloadUsesSignatureFromProvider() throws Exception {
         Assertions.assertTrue(params.has("nonce"));
     }
 
+    @Test
+    void toPayloadFallsBackToBuiltInSignature() throws Exception {
+        Transloadit transloadit = new Transloadit("KEY", "SECRET");
+        Request request = new Request(transloadit);
+
+        Map<String, Object> data = new HashMap<>();
+        Map<String, String> payload = invokeToPayload(request, data);
+        Assertions.assertTrue(payload.containsKey("signature"));
+        Assertions.assertTrue(payload.get("signature").startsWith("sha384:"));
+    }
+
     @Test
     void toPayloadWrapsProviderExceptions() throws Exception {
         SignatureProvider provider = params -> {

src/test/java/com/transloadit/sdk/TransloaditTest.java

@@ -68,11 +68,15 @@ public void getHostUrl() {
     @Test
     public void constructorWithSignatureProviderEnablesSigning() {
         SignatureProvider provider = params -> "signature";
-        Transloadit client = new Transloadit("KEY", provider, "http://localhost:" + PORT);
-
-        Assertions.assertSame(provider, client.getSignatureProvider());
-        Assertions.assertTrue(client.shouldSignRequest);
-        Assertions.assertNull(client.secret);
+        Transloadit urlClient = new Transloadit("KEY", provider, "http://localhost:" + PORT);
+        Transloadit defaultClient = new Transloadit("KEY", provider);
+
+        Assertions.assertSame(provider, urlClient.getSignatureProvider());
+        Assertions.assertSame(provider, defaultClient.getSignatureProvider());
+        Assertions.assertTrue(urlClient.shouldSignRequest);
+        Assertions.assertTrue(defaultClient.shouldSignRequest);
+        Assertions.assertNull(urlClient.secret);
+        Assertions.assertNull(defaultClient.secret);
     }
 
     /**
@@ -93,6 +97,11 @@ public void setSignatureProviderTogglesSigningBasedOnSecret() {
         Transloadit withSecret = new Transloadit("KEY", "SECRET", "http://localhost:" + PORT);
         withSecret.setSignatureProvider(null);
         Assertions.assertTrue(withSecret.shouldSignRequest);
+
+        Transloadit withSecretDefaultUrl = new Transloadit("KEY", "SECRET");
+        withSecretDefaultUrl.setSignatureProvider(provider);
+        Assertions.assertTrue(withSecretDefaultUrl.shouldSignRequest);
+        Assertions.assertSame(provider, withSecretDefaultUrl.getSignatureProvider());
     }
 
     @Test