Skip to content

Commit 0c8f749

Browse files
committed
all tests green.
we still need to write actual tests for the filters in a real scenario.
1 parent f5d0c03 commit 0c8f749

1 file changed

Lines changed: 9 additions & 29 deletions

File tree

‎test/composable_test.rb‎

Lines changed: 9 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ def model(ctx, id:, **)
6868
]
6969
]
7070

71-
input_node = Trailblazer::Activity::VariableMapping::Build::Input.node_for_filters(
71+
input_node = Trailblazer::Activity::VariableMapping::Build::Input.( # DISCUSS: shouldn't we use {DSL::Input.node_for_tuples} here?
7272
array_of_filter_rows,
7373
add_default_ctx: true
7474
)
@@ -289,38 +289,18 @@ def assert_output(node, original_application_ctx:, mutable_ctx:, expected_applic
289289
end
290290

291291
it "DSL.node_for_input, default context without any whitelisting" do
292-
input_node = Trailblazer::Activity::VariableMapping::DSL.node_for_input()
292+
input_node = Trailblazer::Activity::VariableMapping::DSL::Input.node_for_tuples([], add_default_ctx: true)
293293

294-
lib_ctx, flow_options = assert_run input_node, node: true, seq: []
295-
296-
pp input_node
297-
298-
assert_equal flow_options[:application_ctx].class, Trailblazer::Activity::VariableMapping::Context
299-
assert_equal flow_options[:application_ctx].to_h, {seq: []}
300-
301-
assert_equal flow_options.keys, [:application_ctx]
302-
303-
my_model_tw = Pipeline(
304-
my_model_call_task
305-
)
294+
assert_input input_node,
295+
{bogus: true},
296+
{bogus: true}
306297
end
307298

308299
it "blacklist everything" do
309-
# In() => MoreModelInput
310-
more_model_input = Class.new do
311-
# Step interface.
312-
def self.call(ctx, slug:, **)
313-
{
314-
slug: slug.downcase
315-
}
316-
end
317-
end
318-
300+
input_node = Trailblazer::Activity::VariableMapping::DSL::Input.node_for_tuples([], add_default_ctx: false)
319301

320-
321-
# tuples = {Trailblazer::Activity::VariableMapping::DSL.In() => []}
322-
tuples = {Trailblazer::Activity::VariableMapping::DSL.In() => [:params]}
323-
324-
input_node = Trailblazer::Activity::VariableMapping::DSL.node_for_input(tuples: tuples)
302+
assert_input input_node,
303+
{bogus: true},
304+
{}
325305
end
326306
end

0 commit comments

Comments
 (0)