Skip to content

Commit ab51ba5

Browse files
authored
👷 ci(news): stop cancelling the news check (#302)
Opening a pull request with labels, as `gh pr create --label` does, fires `labeled` a moment after `opened`. Both started the news check, and the concurrency group cancelled the first run, which the PR then listed as a failed `📝 News fragment` check while the other run passed. 👷 This moves the news check to [github-workflows 6.3.0](tox-dev/github-workflows#40), whose `validate-news` passes at once for a label set within a minute of opening since the run for opening already reads the current labels, and stops cancelling runs in progress. The check keeps its name, so the ruleset needs no change.
1 parent 1a354de commit ab51ba5

1 file changed

Lines changed: 2 additions & 5 deletions

File tree

‎.github/workflows/news.yaml‎

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@ name: 📝 Changelog
22
on:
33
pull_request:
44
types: [opened, reopened, synchronize, labeled, unlabeled]
5-
concurrency:
6-
group: ${{ github.workflow }}-${{ github.event.pull_request.number }}
7-
cancel-in-progress: true
85
permissions:
96
contents: read
107
pull-requests: read
@@ -25,9 +22,9 @@ jobs:
2522
python-version: "3.15"
2623
enable-cache: false
2724
- name: 📦 Install locked release tools
28-
uses: tox-dev/github-workflows/install-locked-tools@57a765127aae73adf7d0e24a7fe0f067f2d3ea3e # 6.2.1
25+
uses: tox-dev/github-workflows/install-locked-tools@99024bcb5749b178c5514f86acfcf1e80c865e75 # 6.3.0
2926
with:
3027
groups: release-news
3128
venv: ${{ runner.temp }}/release-tools
3229
- name: 🔍 Validate news fragments
33-
uses: tox-dev/github-workflows/validate-news@57a765127aae73adf7d0e24a7fe0f067f2d3ea3e # 6.2.1
30+
uses: tox-dev/github-workflows/validate-news@99024bcb5749b178c5514f86acfcf1e80c865e75 # 6.3.0

0 commit comments

Comments
 (0)