Commit e4db63d
committed
Merge #2171: docs(issues): publish SI-4 torrent cleanup specification
1cacd68 docs(review): document PR #2171 Copilot suggestions audit (Jose Celano)
26d706d docs(issues): clarify torrent cleanup specification (Jose Celano)
1440af2 docs(issues): publish SI-4 torrent cleanup specification (Jose Celano)
Pull request description:
## Summary
Publishes the approved specification for #2169, SI-4 in the #1488 shutdown roadmap.
- Replaces the outdated pre-spawned `JoinHandle` proposal with an unspawned, token-aware cleanup runner directly owned by `JobManager::spawn`.
- Defines explicit normal outcomes for cancellation and weak-manager expiry.
- Requires deterministic lifecycle and named-supervisor-outcome tests.
- Adds direct-binary SIGTERM verification and a functional inactive-peer cleanup scenario through the REST API.
- Requires a separately committed reusable manual cleanup verification skill after the manual scenario establishes the exact procedure.
Related to #2169
## Validation
- `linter all`
- `git diff --check`
- Mandatory pre-commit checks
- Pre-push checks: nightly format and workspace checks, documentation build, and full test suite
ACKs for top commit:
josecelano:
ACK 1cacd68
Tree-SHA512: 99b08b20a5e9d700502d212a44cd3a93135e9f5de6586ba71f0fe04560949884877cfd150ffa81a76452ac445490b04300a31c2ce78aadc3e36b895c79b8d6305 files changed
Lines changed: 308 additions & 148 deletions
File tree
- docs
- copilot-pr-reviews
- issues
- drafts/1488-si-4-migrate-torrent-cleanup
- open
- 1488-overhaul-tracker-shutdown
- 2169-1488-si-4-migrate-torrent-cleanup
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
Lines changed: 0 additions & 147 deletions
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
152 | 152 | | |
153 | 153 | | |
154 | 154 | | |
155 | | - | |
| 155 | + | |
156 | 156 | | |
157 | 157 | | |
158 | 158 | | |
| |||
0 commit comments