Don't show pass / fail until all reviews are complete

Author: jmgasper

src/apps/review/src/lib/components/common/reviewResult.spec.ts

@@ -0,0 +1,105 @@
+import { resolveSubmissionReviewResult } from './reviewResult'
+import type { AggregatedReviewDetail, SubmissionRow } from './types'
+
+const DEFAULT_PASSING_SCORE = 80
+
+const buildSubmission = (
+    reviews: AggregatedReviewDetail[],
+    averageFinalScore?: number,
+): SubmissionRow => {
+    const submissionInfo = {
+        id: 'submission-1',
+        memberId: 'member-1',
+    }
+
+    return {
+        ...submissionInfo,
+        aggregated: {
+            averageFinalScore,
+            id: submissionInfo.id,
+            reviews: reviews.map(review => ({ ...review })),
+            submission: submissionInfo,
+        },
+    }
+}
+
+describe('resolveSubmissionReviewResult', () => {
+    it('returns undefined when any reviewer is still pending in a multi-review setup', () => {
+        const submission = buildSubmission([
+            {
+                finalScore: 92,
+                resourceId: 'res-1',
+                status: 'COMPLETED',
+            },
+            {
+                resourceId: 'res-2',
+            },
+        ], 92)
+
+        const result = resolveSubmissionReviewResult(submission, {
+            defaultMinimumPassingScore: DEFAULT_PASSING_SCORE,
+        })
+
+        expect(result)
+            .toBeUndefined()
+    })
+
+    it('returns PASS once all reviewers have completed their assessments', () => {
+        const submission = buildSubmission([
+            {
+                finalScore: 88,
+                resourceId: 'res-1',
+                status: 'COMPLETED',
+            },
+            {
+                finalScore: 84,
+                resourceId: 'res-2',
+                status: 'SUBMITTED',
+            },
+        ], 86)
+
+        const result = resolveSubmissionReviewResult(submission, {
+            defaultMinimumPassingScore: DEFAULT_PASSING_SCORE,
+        })
+
+        expect(result)
+            .toBe('PASS')
+    })
+
+    it('considers reviews complete when final scores exist even without explicit statuses', () => {
+        const submission = buildSubmission([
+            {
+                finalScore: 90,
+                resourceId: 'res-1',
+            },
+            {
+                finalScore: 82,
+                resourceId: 'res-2',
+            },
+        ], 86)
+
+        const result = resolveSubmissionReviewResult(submission, {
+            defaultMinimumPassingScore: DEFAULT_PASSING_SCORE,
+        })
+
+        expect(result)
+            .toBe('PASS')
+    })
+
+    it('does not defer outcomes for single-review assignments', () => {
+        const submission = buildSubmission([
+            {
+                finalScore: 91,
+                resourceId: 'res-1',
+                status: 'PENDING',
+            },
+        ], 91)
+
+        const result = resolveSubmissionReviewResult(submission, {
+            defaultMinimumPassingScore: DEFAULT_PASSING_SCORE,
+        })
+
+        expect(result)
+            .toBe('PASS')
+    })
+})

src/apps/review/src/lib/components/common/reviewResult.ts

@@ -1,4 +1,4 @@
-import type { SubmissionRow } from './types'
+import type { AggregatedReviewDetail, SubmissionRow } from './types'
 
 export type ReviewOutcome = 'PASS' | 'FAIL'
 
@@ -38,6 +38,71 @@ const OUTCOME_KEYS = [
 
 type MetadataObject = Record<string, unknown>
 
+const COMPLETED_REVIEW_STATUSES = new Set(['COMPLETED', 'SUBMITTED'])
+
+const normalizeStatusString = (value: unknown): string | undefined => {
+    if (typeof value !== 'string') {
+        return undefined
+    }
+
+    const normalized = value.trim()
+        .toUpperCase()
+    return normalized.length ? normalized : undefined
+}
+
+const isAggregatedReviewDetailCompleted = (detail: AggregatedReviewDetail): boolean => {
+    const statusCandidates = [
+        detail.status,
+        detail.reviewInfo?.status,
+    ]
+
+    for (const candidate of statusCandidates) {
+        const normalized = normalizeStatusString(candidate)
+        if (normalized) {
+            return COMPLETED_REVIEW_STATUSES.has(normalized)
+        }
+    }
+
+    const committedCandidates = [
+        detail.reviewInfo?.committed,
+    ]
+
+    if (committedCandidates.some(value => value === false)) {
+        return false
+    }
+
+    if (committedCandidates.some(value => value === true)) {
+        return true
+    }
+
+    const finalScoreCandidates = [
+        detail.finalScore,
+        detail.reviewInfo?.finalScore,
+    ]
+
+    return finalScoreCandidates.some(value => typeof value === 'number' && Number.isFinite(value))
+}
+
+const shouldDeferAggregatedOutcome = (submission: SubmissionRow): boolean => {
+    const aggregatedReviews = submission.aggregated?.reviews
+    if (!aggregatedReviews || aggregatedReviews.length === 0) {
+        return false
+    }
+
+    const assignedReviews = aggregatedReviews.filter(review => (
+        Boolean(review.resourceId)
+        || Boolean(review.reviewInfo?.resourceId)
+        || Boolean(review.reviewId)
+        || Boolean(review.reviewerHandle ?? review.reviewInfo?.reviewerHandle)
+    ))
+
+    if (assignedReviews.length <= 1) {
+        return false
+    }
+
+    return !assignedReviews.every(isAggregatedReviewDetailCompleted)
+}
+
 const isRecord = (value: unknown): value is MetadataObject => (
     typeof value === 'object'
     && value !== null
@@ -317,6 +382,10 @@ export function resolveSubmissionReviewResult(
         defaultMinimumPassingScore,
     }: ResolveSubmissionReviewResultOptions = options
 
+    if (shouldDeferAggregatedOutcome(submission)) {
+        return undefined
+    }
+
     const metadataCandidates = collectMetadataCandidates(submission)
 
     const metadataOutcome = metadataCandidates