Skip to content

[TCL 2840] Filter pod listwatcher to limit number of events to process #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Part-TimeWizard wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[TCL 2840] Filter pod listwatcher to limit number of events to process #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions pkg/watcher/watcher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,18 @@ package watcher

import (
kapi "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/fields"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/labels"
"k8s.io/client-go/tools/cache"

k8sClient "github.com/Mellanox/ib-kubernetes/pkg/k8s-client"
resEventHandler "github.com/Mellanox/ib-kubernetes/pkg/watcher/handler"
)

var (
kubevirtSelectorString = SelectorMustValidateFromSet(labels.Set{"kubevirt.io": "virt-launcher"}).String()
)

type StopFunc func()

type Watcher interface {
Expand All @@ -25,7 +30,11 @@ type watcher struct {

func NewWatcher(eventHandler resEventHandler.ResourceEventHandler, client k8sClient.Client) Watcher {
resource := eventHandler.GetResourceObject().GetObjectKind().GroupVersionKind().Kind
watchList := cache.NewListWatchFromClient(client.GetRestClient(), resource, kapi.NamespaceAll, fields.Everything())
filterByKubevirtLabel := func(options *metav1.ListOptions) {

options.LabelSelector = kubevirtSelectorString
}
watchList := cache.NewFilteredListWatchFromClient(client.GetRestClient(), resource, kapi.NamespaceAll, filterByKubevirtLabel)
return &watcher{eventHandler: eventHandler, watchList: watchList}
}

Expand All @@ -48,3 +57,12 @@ func (w *watcher) RunBackground() StopFunc {
func (w *watcher) GetHandler() resEventHandler.ResourceEventHandler {
return w.eventHandler
}

// SelectorMustValidateFromSet acts like regex.MustCompile for labels.Selector objects. It will attempt to validate the selector from the label set and panic if it fails.
func SelectorMustValidateFromSet(set labels.Set) labels.Selector {
selector, err := labels.ValidatedSelectorFromSet(set)
if err != nil {
panic(err)
}
return selector
}