avoid to unbound other target on startup when port allocation conflict

Signed-off-by: roc <[email protected]>

Author: imroc

cmd/app/manager.go

@@ -81,7 +81,6 @@ func runManager() {
 	// setup manager
 	SetupManager(mgr, opts)
 
-	// TODO: remove the tricky code in the future
 	networkingv1alpha1.Init(mgr)
 	kube.Init(mgr)
 

cmd/app/setup_controller.go

@@ -1,13 +1,16 @@
 package app
 
 import (
+	"context"
 	"os"
 
 	"github.com/tkestack/tke-extend-network-controller/internal/clbbinding"
 	"github.com/tkestack/tke-extend-network-controller/internal/controller"
 	"github.com/tkestack/tke-extend-network-controller/pkg/clusterinfo"
 	"github.com/tkestack/tke-extend-network-controller/pkg/util"
+	corev1 "k8s.io/api/core/v1"
 	ctrl "sigs.k8s.io/controller-runtime"
+	"sigs.k8s.io/controller-runtime/pkg/client"
 )
 
 func SetupControllers(mgr ctrl.Manager) {
@@ -55,6 +58,10 @@ func SetupControllers(mgr ctrl.Manager) {
 		setupLog.Error(err, "unable to create controller", "controller", "Pod")
 		os.Exit(1)
 	}
+	mgr.GetFieldIndexer().IndexField(context.Background(), &corev1.Pod{}, "status.podIP", func(o client.Object) []string {
+		pod := o.(*corev1.Pod)
+		return []string{pod.Status.PodIP}
+	})
 
 	// Node controller
 	if err := (&controller.NodeReconciler{
@@ -67,6 +74,17 @@ func SetupControllers(mgr ctrl.Manager) {
 		setupLog.Error(err, "unable to create controller", "controller", "Node")
 		os.Exit(1)
 	}
+	mgr.GetFieldIndexer().IndexField(context.Background(), &corev1.Node{}, "status.nodeIP", func(o client.Object) []string {
+		node := o.(*corev1.Node)
+		ret := []string{}
+		for _, addr := range node.Status.Addresses {
+			if addr.Type == corev1.NodeInternalIP {
+				ret = append(ret, addr.Address)
+				break
+			}
+		}
+		return ret
+	})
 
 	// GameServerSet controller
 	if clusterinfo.OKGSupported {

internal/clbbinding/clbbinding.go

@@ -13,6 +13,7 @@ type CLBBinding interface {
 	GetSpec() *networkingv1alpha1.CLBBindingSpec
 	GetStatus() *networkingv1alpha1.CLBBindingStatus
 	GetAssociatedObject(context.Context, client.Client) (Backend, error)
+	GetAssociatedObjectByIP(context.Context, client.Client, string) (Backend, error)
 	GetObject() client.Object
 	GetType() string
 	FetchObject(context.Context, client.Client) (client.Object, error)

internal/clbbinding/clbnodebinding.go

@@ -88,3 +88,16 @@ func (b *CLBNodeBinding) GetAssociatedObject(ctx context.Context, apiClient clie
 	}
 	return nodeBackend{node}, nil
 }
+
+func (b *CLBNodeBinding) GetAssociatedObjectByIP(ctx context.Context, apiClient client.Client, ip string) (Backend, error) {
+	nodeList := &corev1.NodeList{}
+	if err := apiClient.List(ctx, nodeList, client.MatchingFields{
+		"status.nodeIP": ip,
+	}); err != nil {
+		return nil, errors.WithStack(err)
+	}
+	if len(nodeList.Items) > 0 {
+		return nodeBackend{&nodeList.Items[0]}, nil
+	}
+	return nil, nil
+}

internal/clbbinding/clbpodbinding.go

@@ -93,6 +93,19 @@ func (b podBackend) TriggerReconcile() {
 	}
 }
 
+func (b *CLBPodBinding) GetAssociatedObjectByIP(ctx context.Context, apiClient client.Client, ip string) (Backend, error) {
+	podList := &corev1.PodList{}
+	if err := apiClient.List(ctx, podList, client.MatchingFields{
+		"status.podIP": ip,
+	}); err != nil {
+		return nil, errors.WithStack(err)
+	}
+	if len(podList.Items) > 0 {
+		return podBackend{&podList.Items[0], apiClient}, nil
+	}
+	return nil, nil
+}
+
 func (b *CLBPodBinding) GetAssociatedObject(ctx context.Context, apiClient client.Client) (Backend, error) {
 	pod := &corev1.Pod{}
 	if err := apiClient.Get(ctx, client.ObjectKeyFromObject(b), pod); err != nil {

internal/controller/clbbinding.go

@@ -652,6 +652,18 @@ func (r *CLBBindingReconciler[T]) ensurePortBound(ctx context.Context, bd clbbin
 	}
 	// 清理多余的 rs
 	if len(targetToDelete) > 0 {
+		for _, target := range targetToDelete {
+			ip := target.TargetIP
+			backend, err := bd.GetAssociatedObjectByIP(ctx, r.Client, ip)
+			if err != nil {
+				return errors.WithStack(err)
+			}
+			if backend != nil {
+				msg := fmt.Sprintf("port conflict due to %s:%d/%s is already bound to %s", binding.LoadbalancerId, binding.LoadbalancerPort, binding.Protocol, backend.GetName())
+				r.Recorder.Event(bd.GetObject(), corev1.EventTypeWarning, "OtherTargetBound", msg)
+				return nil
+			}
+		}
 		r.Recorder.Eventf(bd.GetObject(), corev1.EventTypeNormal, "DeregisterTarget", "remove unexpected target: %v", targetToDelete)
 		if err := clb.DeregisterTargetsForListenerTryBatch(ctx, binding.Region, binding.LoadbalancerId, binding.ListenerId, targetToDelete...); err != nil {
 			return errors.WithStack(err)