Skip to content

Commit 99c3395

Browse files
timvisher-ddclaude
andcommitted
Document why restart-preserves-default-directory test skips in batch
The `agent-shell-restart-preserves-default-directory' test calls `make-frame' on a hidden frame to drive an interactive restart flow, which fails with "Unknown terminal type" under emacs --batch. Upstream guards the body with `(skip-unless (not noninteractive))'; add a comment above it explaining the constraint so a future reader doesn't mistake the skip for an unfinished test. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent f10476a commit 99c3395

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

‎tests/agent-shell-tests.el‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2601,6 +2601,8 @@ Based on ACP traffic from https://github.com/xenodium/agent-shell/issues/415."
26012601
After `kill-buffer' happens during restart, Emacs falls back to another
26022602
buffer. Without the fix, `default-directory' would be inherited from
26032603
that fallback buffer, potentially starting the new shell in the wrong project."
2604+
;; `make-frame' below requires a real terminal, so this test cannot
2605+
;; run in batch mode where Emacs has no controlling terminal.
26042606
(skip-unless (not noninteractive))
26052607
(let ((shell-buffer nil)
26062608
(other-buffer nil)

0 commit comments

Comments
 (0)