Switch to @openzeppelin/[email protected]

[nkuba]

@openzeppelin/contracts released version 4.6.0 which is not compatible with our current implementation (we use 4.5 at the moment). Do we want to backlog switching to the latest version 4.6.0?

For 4.6.0 contracts compilation fails:

TypeError: Function needs to specify overridden contract "Governor".
   --> contracts/governance/BaseTokenholderGovernor.sol:101:9:
    |
101 |         override(IGovernor, TokenholderGovernorVotes)
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Note: This contract: 
  --> @openzeppelin/contracts/governance/Governor.sol:29:1:
   |
29 | abstract contract Governor is Context, ERC165, EIP712, IGovernor, IERC721Receiver, IERC1155Receiver {
   | ^ (Relevant source part starts here and spans across multiple lines).


TypeError: Invalid contract specified in override list: "GovernorPreventLateQuorum".
   --> contracts/governance/BaseTokenholderGovernor.sol:171:9:
    |
171 |         override(Governor, GovernorPreventLateQuorum)
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Note: This contract: 
  --> @openzeppelin/contracts/governance/extensions/GovernorPreventLateQuorum.sol:20:1:
   |
20 | abstract contract GovernorPreventLateQuorum is Governor {
   | ^ (Relevant source part starts here and spans across multiple lines).


TypeError: Derived contract must override function "_castVote". Two or more base classes define function with same name and parameter types.
  --> contracts/governance/BaseTokenholderGovernor.sol:26:1:
   |
26 | contract BaseTokenholderGovernor is
   | ^ (Relevant source part starts here and spans across multiple lines).
Note: Definition in "Governor": 
   --> @openzeppelin/contracts/governance/Governor.sol:515:5:
    |
515 |     function _castVote(
    |     ^ (Relevant source part starts here and spans across multiple lines).
Note: Definition in "GovernorPreventLateQuorum": 
  --> @openzeppelin/contracts/governance/extensions/GovernorPreventLateQuorum.sol:56:5:
   |
56 |     function _castVote(
   |     ^ (Relevant source part starts here and spans across multiple lines).


TypeError: Contract "BaseTokenholderGovernor" should be marked as abstract.
  --> contracts/governance/BaseTokenholderGovernor.sol:26:1:
   |
26 | contract BaseTokenholderGovernor is
   | ^ (Relevant source part starts here and spans across multiple lines).
Note: Missing implementation: 
   --> @openzeppelin/contracts/governance/Governor.sol:213:5:
    |
213 |     function _getVotes(
    |     ^ (Relevant source part starts here and spans across multiple lines).


TypeError: Contract "TokenholderGovernor" should be marked as abstract.
  --> contracts/governance/TokenholderGovernor.sol:20:1:
   |
20 | contract TokenholderGovernor is BaseTokenholderGovernor {
   | ^ (Relevant source part starts here and spans across multiple lines).
Note: Missing implementation: 
   --> @openzeppelin/contracts/governance/Governor.sol:213:5:
    |
213 |     function _getVotes(
    |     ^ (Relevant source part starts here and spans across multiple lines).


TypeError: Function needs to specify overridden contract "Governor".
   --> contracts/governance/StakerGovernor.sol:116:9:
    |
116 |         override(IGovernor, StakerGovernorVotes)
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Note: This contract: 
  --> @openzeppelin/contracts/governance/Governor.sol:29:1:
   |
29 | abstract contract Governor is Context, ERC165, EIP712, IGovernor, IERC721Receiver, IERC1155Receiver {
   | ^ (Relevant source part starts here and spans across multiple lines).


TypeError: Contract "StakerGovernor" should be marked as abstract.
  --> contracts/governance/StakerGovernor.sol:27:1:
   |
27 | contract StakerGovernor is
   | ^ (Relevant source part starts here and spans across multiple lines).
Note: Missing implementation: 
   --> @openzeppelin/contracts/governance/Governor.sol:213:5:
    |
213 |     function _getVotes(
    |     ^ (Relevant source part starts here and spans across multiple lines).


TypeError: Contract "TestStakerGovernor" should be marked as abstract.
  --> contracts/test/TestGovernorTestSet.sol:24:1:
   |
24 | contract TestStakerGovernor is StakerGovernor {
   | ^ (Relevant source part starts here and spans across multiple lines).
Note: Missing implementation: 
   --> @openzeppelin/contracts/governance/Governor.sol:213:5:
    |
213 |     function _getVotes(
    |     ^ (Relevant source part starts here and spans across multiple lines).


TypeError: Contract "TestTokenholderGovernor" should be marked as abstract.
  --> contracts/test/TestGovernorTestSet.sol:43:1:
   |
43 | contract TestTokenholderGovernor is BaseTokenholderGovernor {
   | ^ (Relevant source part starts here and spans across multiple lines).
Note: Missing implementation: 
   --> @openzeppelin/contracts/governance/Governor.sol:213:5:
    |
213 |     function _getVotes(
    |     ^ (Relevant source part starts here and spans across multiple lines).


TypeError: Function has override specified but does not override anything.
   --> contracts/test/TestGovernorTestSet.sol:116:24:
    |
116 |     ) internal virtual override {}
    |                        ^^^^^^^^


TypeError: Contract "TestGovernorParameters" should be marked as abstract.
  --> contracts/test/TestGovernorTestSet.sol:70:1:
   |
70 | contract TestGovernorParameters is GovernorParameters {
   | ^ (Relevant source part starts here and spans across multiple lines).
Note: Missing implementation: 
   --> @openzeppelin/contracts/governance/Governor.sol:224:5:
    |
224 |     function _countVote(
    |     ^ (Relevant source part starts here and spans across multiple lines).
Note: Missing implementation: 
   --> @openzeppelin/contracts/governance/Governor.sol:213:5:
    |
213 |     function _getVotes(
    |     ^ (Relevant source part starts here and spans across multiple lines).


TypeError: Function has override specified but does not override anything.
  --> contracts/test/TestStakerGovernorVotes.sol:44:24:
   |
44 |     ) internal virtual override {}
   |                        ^^^^^^^^


TypeError: Contract "TestStakerGovernorVotes" should be marked as abstract.
 --> contracts/test/TestStakerGovernorVotes.sol:7:1:
  |
7 | contract TestStakerGovernorVotes is StakerGovernorVotes {
  | ^ (Relevant source part starts here and spans across multiple lines).
Note: Missing implementation: 
   --> @openzeppelin/contracts/governance/Governor.sol:224:5:
    |
224 |     function _countVote(
    |     ^ (Relevant source part starts here and spans across multiple lines).
Note: Missing implementation: 
   --> @openzeppelin/contracts/governance/Governor.sol:213:5:
    |
213 |     function _getVotes(
    |     ^ (Relevant source part starts here and spans across multiple lines).


TypeError: Function has override specified but does not override anything.
  --> contracts/test/TestTokenholderGovernorVotes.sol:46:24:
   |
46 |     ) internal virtual override {}
   |                        ^^^^^^^^


TypeError: Contract "TestTokenholderGovernorVotes" should be marked as abstract.
 --> contracts/test/TestTokenholderGovernorVotes.sol:9:1:
  |
9 | contract TestTokenholderGovernorVotes is TokenholderGovernorVotes {
  | ^ (Relevant source part starts here and spans across multiple lines).
Note: Missing implementation: 
   --> @openzeppelin/contracts/governance/Governor.sol:224:5:
    |
224 |     function _countVote(
    |     ^ (Relevant source part starts here and spans across multiple lines).
Note: Missing implementation: 
   --> @openzeppelin/contracts/governance/Governor.sol:213:5:
    |
213 |     function _getVotes(
    |     ^ (Relevant source part starts here and spans across multiple lines).


Warning: Visibility for constructor is ignored. If you want the contract to be non-deployable, making it "abstract" is sufficient.
  --> contracts/test/KeepRegistryStub.sol:12:5:
   |
12 |     constructor() public {
   |     ^ (Relevant source part starts here and spans across multiple lines).


Error HH600: Compilation failed

Refs #97

[nkuba]

@cygnusv @pdyraga ^^