Switch from PyYAML to ruamel.yaml #72
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a more modern fork which: 1. Uses YAML 1.3, 2. Has some neat round-tripping functionality, 3. Is regularly maintained, 4. Isn't (as of the time of this commit) using deprecated APIs which will break in the next major Python release.
While the YAML we're loading isn't actually untrusted, we do not have a use case for instantiating arbitrary Python objects from the config files so it's much safer to just not do this.
danpalmer
approved these changes
Oct 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruamel.yamlis a more modern fork of PyYAML, which: