-
-
Notifications
You must be signed in to change notification settings - Fork 476
feat: add theme option for today in datepicker #1627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 488f050 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
The preview‑deployment docs don’t appear to include the new "today" key in the theme configuration. Is there anything missing that needs updating? |
|
@jonasho Nope, forgot about it, I'm seeing it there. Mobile app for github is terrible. Where don't you see the today in the docs? |
|
@rluders—never mind, I found it. The search on the preview stage redirected me to the official site; I didn’t notice that earlier. Looks good now. |
SutuSebastian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this!
only thing left to add is a changeset that bump the flowbite-react package as a patch.
u can do that by running bun changeset and the CLI will prompt to select the package first, then what version to bump, just press enter, patch is the last.
|
@jonasho is attempting to deploy a commit to the Themesberg Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThis PR introduces a new "today" theme option for the Datepicker component. It adds a helper function to identify today's date, extends the theme interface to include today styling, and applies the today class to the current date in the Days view. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
🧰 Additional context used🧠 Learnings (1)📚 Learning: 2024-07-27T04:19:32.056ZApplied to files:
🧬 Code graph analysis (1)packages/ui/src/components/Datepicker/Views/Days.tsx (1)
🔇 Additional comments (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Updated Days.tsx to detect the current day and apply a theme attribute, giving users an easy reference.
Summary by CodeRabbit