Wrong terminology in stdout from "foreman-maintain backup offline"

[maximiliankolb]

If you perform an offline backup, foreman-maintain writes "local proxy" to stdout. This is confusing and does not match Foreman/Katello terminology. Instead, it should say "Smart Proxy".

Reproducer

. SSH to Foreman/Katello
. Run foreman-maintain backup offline /var/my_dir/
. Follow stdout.

Actual result

--------------------------------------------------------------------------------
Detect features available in the local proxy:                         [OK]
--------------------------------------------------------------------------------

Expected Result

--------------------------------------------------------------------------------
Detect features available in Smart Proxy:                             [OK]
--------------------------------------------------------------------------------

Reasoning

It's always either "Smart Proxy" for Foreman server and any Smart Proxy servers, or "Smart Proxy server" for all Smart Proxy servers. There is no need for descriptions such as "local" or "integrated". See https://github.com/theforeman/foreman-documentation/blob/master/guides/common/attributes-base.adoc#L148

• in foreman_maintain: definitions/procedures/foreman_proxy/features.rb
• in robottelo: robottelo/cli/sm_advanced.py