ci: Do not distrubute production build to public

Author: bummoblizard

.github/workflows/build.yml

@@ -19,7 +19,7 @@ jobs:
           fetch-depth: 0
 
       - name: Deploy iOS Beta to TestFlight via Fastlane
-        run: fastlane open_beta
+        run: fastlane beta
         env:
           APP_STORE_CONNECT_TEAM_ID: "${{ secrets.APP_STORE_CONNECT_TEAM_ID }}"
           DEVELOPER_APP_ID: "${{ secrets.DEVELOPER_APP_ID }}"
@@ -38,6 +38,7 @@ jobs:
           APPLE_KEY_CONTENT: "${{ secrets.APPLE_KEY_CONTENT }}"
           JUDGE0_KEY: ""
           JUDGE0_ENDPOINT: ""
+          DISTRIBUTE_EXTERNAL: "true"
 
       - name: Upload Artifact
         uses: actions/upload-artifact@v3

.github/workflows/production.yml

@@ -17,7 +17,7 @@ jobs:
           fetch-depth: 0
 
       - name: Deploy production build to App Store via Fastlane
-        run: fastlane open_beta
+        run: fastlane beta
         env:
           APP_STORE_CONNECT_TEAM_ID: "${{ secrets.APP_STORE_CONNECT_TEAM_ID }}"
           DEVELOPER_APP_ID: "${{ secrets.DEVELOPER_APP_ID }}"
@@ -36,3 +36,4 @@ jobs:
           APPLE_KEY_CONTENT: "${{ secrets.APPLE_KEY_CONTENT }}"
           JUDGE0_KEY: "${{ secrets.JUDGE0_KEY }}"
           JUDGE0_ENDPOINT: "${{ secrets.JUDGE0_ENDPOINT }}"
+          DISTRIBUTE_EXTERNAL: "false"

fastlane/Fastfile

@@ -12,6 +12,7 @@ GIT_AUTHORIZATION = ENV["GIT_AUTHORIZATION"]
 
 JUDGE0_KEY = ENV["JUDGE0_KEY"]
 JUDGE0_ENDPOINT = ENV["JUDGE0_ENDPOINT"]
+DISTRIBUTE_EXTERNAL = ENV["DISTRIBUTE_EXTERNAL"] == "true"
 
 def delete_temp_keychain(name)
   delete_keychain(
@@ -34,7 +35,7 @@ def ensure_temp_keychain(name, password)
 end
 
 platform :ios do
-  lane :open_beta do
+  lane :beta do
     keychain_name = TEMP_KEYCHAIN_USER
     keychain_password = TEMP_KEYCHAIN_PASSWORD
     ensure_temp_keychain(keychain_name, keychain_password)
@@ -82,7 +83,7 @@ platform :ios do
     pilot(
       apple_id: "#{DEVELOPER_APP_ID}",
       app_identifier: "#{DEVELOPER_APP_IDENTIFIER}",
-      distribute_external: true,
+      distribute_external: DISTRIBUTE_EXTERNAL,
       notify_external_testers: true,
       ipa: "./Code.ipa",
       changelog: "GitHub Action automatic build. For detailed changes, " + 
@@ -91,6 +92,7 @@ platform :ios do
       groups: ["Public"],
       wait_processing_interval: 300
     )
+    
 
     delete_temp_keychain(keychain_name)
   end

fastlane/README.md

@@ -15,10 +15,10 @@ For _fastlane_ installation instructions, see [Installing _fastlane_](https://do
 
 ## iOS
 
-### ios open_beta
+### ios beta
 
 ```sh
-[bundle exec] fastlane ios open_beta
+[bundle exec] fastlane ios beta
 ```