git: Call onFinish() even service provider is unavailable

bummoblizard · bummoblizard · commit 6a79786c735c · 2023-08-24T00:31:55.000+08:00
diff --git a/CodeApp/Managers/MainApp.swift b/CodeApp/Managers/MainApp.swift
@@ -667,10 +667,14 @@ class MainApp: ObservableObject {
 
         guard let gitServiceProvider = workSpaceStorage.gitServiceProvider else {
             clearUIState()
+            onFinish()
             return
         }
 
         Task {
+            defer {
+                onFinish()
+            }
             do {
                 let entries = try await gitServiceProvider.status()
                 let (indexed, worktree) = groupStatusEntries(entries: entries)
@@ -713,13 +717,9 @@ class MainApp: ObservableObject {
 
                     self.branch = branchLabel
                 }
-                onFinish()
-
             } catch {
                 clearUIState()
-                onFinish()
             }
-
         }
 
         Task {

Original file line number	Diff line number	Diff line change
`@@ -667,10 +667,14 @@ class MainApp: ObservableObject {`
`667`	`667`
`668`	`668`	`guard let gitServiceProvider = workSpaceStorage.gitServiceProvider else {`
`669`	`669`	`clearUIState()`
	`670`	`+ onFinish()`
`670`	`671`	`return`
`671`	`672`	`}`
`672`	`673`
`673`	`674`	`Task {`
	`675`	`+ defer {`
	`676`	`+ onFinish()`
	`677`	`+ }`
`674`	`678`	`do {`
`675`	`679`	`let entries = try await gitServiceProvider.status()`
`676`	`680`	`let (indexed, worktree) = groupStatusEntries(entries: entries)`
`@@ -713,13 +717,9 @@ class MainApp: ObservableObject {`
`713`	`717`
`714`	`718`	`self.branch = branchLabel`
`715`	`719`	`}`
`716`		`- onFinish()`
`717`		`-`
`718`	`720`	`} catch {`
`719`	`721`	`clearUIState()`
`720`		`- onFinish()`
`721`	`722`	`}`
`722`		`-`
`723`	`723`	`}`
`724`	`724`
`725`	`725`	`Task {`