-
Notifications
You must be signed in to change notification settings - Fork 74
Fix: print styles for web visitors #654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| page-break-after: always; | ||
| } | ||
|
|
||
| /* Styles for web users who wish to print (or "print") the document */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| /* Styles for web users who wish to print (or "print") the document */ | |
| /* Styles for web users who wish to print (or print-to-pdf) the document */ |
I think this is what was meant by the scare quotes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol they weren't meant to be scare quotes, it was meant to communicate that using the "print" function may not be used for the purpose of putting ink (or toner) to paper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me, that means print-to-PDF, and it'd be easier for me to understand by calling it that. If there's other "print" functions, we could list them as examples too. It'd give me something concrete to think about when reading this.
|
Can you go into a little more detail about what this PR actually accomplishes? |
|
It improves the readability of the document for visitors wishing to generate paged media. It's an accessibility improvement. |
|
I get that, but the question was how do these styles and the moved around DOM nodes help the readability? |
I got a little nerd sniped on Mastodon by a conversation about accessibility and print styles. Browsers mostly don't implement the CSS paged media module, and the web version of typical ecmarkup output doesn't use the oldtoc class, so I needed to add just a few little things to make the site printable for web visitors.
Important
I fully admit I appended some print-related event listeners to a javascript file (sdoMap.js) that I didn't otherwise spend the time to totally understand. I'm trusting the baseline knowledge of reviewers for this repo to tell me if that can/should go somewhere else.