Skip to content

Commit 130ef88

Browse files
tdg_dashboard: display only 99th quantile
Display only 99th quantile for Prometheus TDG Kafka metrics: - "TDG Kafka brokers statistics" panels: - "Producer queue latency" (tdg_kafka_broker_int_latency), - "Request queue latency" (tdg_kafka_broker_outbuf_latency), - "Broker latency" (tdg_kafka_broker_rtt), - "Broker throttle" (tdg_kafka_broker_throttle); - "TDG Kafka topics statistics" panels: - "Batch size" (tdg_kafka_topic_batchsize), - "Batch message count" (tdg_kafka_topic_batchcnt). Closes #156
1 parent cb30dba commit 130ef88

File tree

4 files changed

+9
-8
lines changed

4 files changed

+9
-8
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
99
## Fixed
1010
- TDG dashboard file connectors processed panel name changed to "Total files processed"
1111
- Set valid metrics name to TDG dashboard Kafka partitions panels
12+
- Display only 99th quantile for Prometheus TDG Kafka metrics
1213

1314

1415
## [1.2.0] - 2022-06-08

dashboard/panels/tdg/kafka/brokers.libsonnet

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ local prometheus = grafana.prometheus;
7373
) =
7474
if datasource == '${DS_PROMETHEUS}' then
7575
prometheus.target(
76-
expr=std.format('%s{job=~"%s"}',
76+
expr=std.format('%s{job=~"%s",quantile="0.99"}',
7777
[metric_name, job]),
7878
legendFormat='{{name}} ({{broker_name}}) — {{alias}} ({{type}}, {{connector_name}})',
7979
)

dashboard/panels/tdg/kafka/topics.libsonnet

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ local prometheus = grafana.prometheus;
102102
) =
103103
if datasource == '${DS_PROMETHEUS}' then
104104
prometheus.target(
105-
expr=std.format('%s{job=~"%s"}',
105+
expr=std.format('%s{job=~"%s",quantile="0.99"}',
106106
[metric_name, job]),
107107
legendFormat='{{name}} ({{topic}}) — {{alias}} ({{type}}, {{connector_name}})',
108108
)

tests/Prometheus/dashboard_tdg_compiled.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11764,7 +11764,7 @@
1176411764
"steppedLine": false,
1176511765
"targets": [
1176611766
{
11767-
"expr": "tdg_kafka_broker_int_latency{job=~\"$job\"}",
11767+
"expr": "tdg_kafka_broker_int_latency{job=~\"$job\",quantile=\"0.99\"}",
1176811768
"format": "time_series",
1176911769
"intervalFactor": 2,
1177011770
"legendFormat": "{{name}} ({{broker_name}}) — {{alias}} ({{type}}, {{connector_name}})",
@@ -11854,7 +11854,7 @@
1185411854
"steppedLine": false,
1185511855
"targets": [
1185611856
{
11857-
"expr": "tdg_kafka_broker_outbuf_latency{job=~\"$job\"}",
11857+
"expr": "tdg_kafka_broker_outbuf_latency{job=~\"$job\",quantile=\"0.99\"}",
1185811858
"format": "time_series",
1185911859
"intervalFactor": 2,
1186011860
"legendFormat": "{{name}} ({{broker_name}}) — {{alias}} ({{type}}, {{connector_name}})",
@@ -11944,7 +11944,7 @@
1194411944
"steppedLine": false,
1194511945
"targets": [
1194611946
{
11947-
"expr": "tdg_kafka_broker_rtt{job=~\"$job\"}",
11947+
"expr": "tdg_kafka_broker_rtt{job=~\"$job\",quantile=\"0.99\"}",
1194811948
"format": "time_series",
1194911949
"intervalFactor": 2,
1195011950
"legendFormat": "{{name}} ({{broker_name}}) — {{alias}} ({{type}}, {{connector_name}})",
@@ -12034,7 +12034,7 @@
1203412034
"steppedLine": false,
1203512035
"targets": [
1203612036
{
12037-
"expr": "tdg_kafka_broker_throttle{job=~\"$job\"}",
12037+
"expr": "tdg_kafka_broker_throttle{job=~\"$job\",quantile=\"0.99\"}",
1203812038
"format": "time_series",
1203912039
"intervalFactor": 2,
1204012040
"legendFormat": "{{name}} ({{broker_name}}) — {{alias}} ({{type}}, {{connector_name}})",
@@ -12324,7 +12324,7 @@
1232412324
"steppedLine": false,
1232512325
"targets": [
1232612326
{
12327-
"expr": "tdg_kafka_topic_batchsize{job=~\"$job\"}",
12327+
"expr": "tdg_kafka_topic_batchsize{job=~\"$job\",quantile=\"0.99\"}",
1232812328
"format": "time_series",
1232912329
"intervalFactor": 2,
1233012330
"legendFormat": "{{name}} ({{topic}}) — {{alias}} ({{type}}, {{connector_name}})",
@@ -12414,7 +12414,7 @@
1241412414
"steppedLine": false,
1241512415
"targets": [
1241612416
{
12417-
"expr": "tdg_kafka_topic_batchcnt{job=~\"$job\"}",
12417+
"expr": "tdg_kafka_topic_batchcnt{job=~\"$job\",quantile=\"0.99\"}",
1241812418
"format": "time_series",
1241912419
"intervalFactor": 2,
1242012420
"legendFormat": "{{name}} ({{topic}}) — {{alias}} ({{type}}, {{connector_name}})",

0 commit comments

Comments
 (0)