Skip to content

Commit 176ad4e

Browse files
committed
iproto: add missing IPROTO feature flags to greeting negotiation
The flags of functions IPROTO_FEATURE_IS_SYNC and IPROTO_FEATURE_INSERT_ARROW protocol function flags were added in the welcome, fixed tests that test for flags by adding a byte sequence. Fixed #466 iproto: add missing IPROTO feature flags to greeting negotiation The flags of functions IPROTO_FEATURE_IS_SYNC and IPROTO_FEATURE_INSERT_ARROW protocol function flags were added in the welcome, fixed tests that test for flags by adding a byte sequence. Added #466 squash 2baff9b iproto: add missing IPROTO feature flags to greeting negotiation
1 parent 6111b79 commit 176ad4e

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@ flag handling, and fixes watcher panic.
3636
Now you can check this error with `errors.Is(err, tarantool.ErrConcurrentSchemaUpdate)`.
3737
- Implemented support for `IPROTO_IS_SYNC` flag in stream transactions,
3838
added `IsSync(bool)` method for `BeginRequest`/`CommitRequest` (#447).
39+
- Added missing IPROTO feature flags to greeting negotiation (iproto.IPROTO_FEATURE_IS_SYNC,
40+
iproto.IPROTO_FEATURE_INSERT_ARROW) and fixed tests that test for flags by adding a byte sequence.
3941

4042
### Fixed
4143

dial_test.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ var (
343343
testDialSalt = genSalt()
344344

345345
idRequestExpected = []byte{
346-
0xce, 0x00, 0x00, 0x00, 29, // Length.
346+
0xce, 0x00, 0x00, 0x00, 31, // Length.
347347
0x82, // Header map.
348348
0x00, 0x49,
349349
0x01, 0xce, 0x00, 0x00, 0x00, 0x00,
@@ -352,7 +352,8 @@ var (
352352
0x54,
353353
0xcf, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x06, // Version.
354354
0x55,
355-
0x97, 0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, // Features.
355+
0x99, // Fixed arrау with 9 elements.
356+
0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x0b, 0x0c, // Features (9 elements).
356357
}
357358

358359
idResponseTyped = tarantool.ProtocolInfo{

protocol.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,8 @@ var clientProtocolInfo ProtocolInfo = ProtocolInfo{
5858
iproto.IPROTO_FEATURE_PAGINATION,
5959
iproto.IPROTO_FEATURE_SPACE_AND_INDEX_NAMES,
6060
iproto.IPROTO_FEATURE_WATCH_ONCE,
61+
iproto.IPROTO_FEATURE_IS_SYNC,
62+
iproto.IPROTO_FEATURE_INSERT_ARROW,
6163
},
6264
}
6365

0 commit comments

Comments
 (0)