Skip to content

fix: update escape character for sqlite #2512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: update escape character for sqlite #2512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 2 additions & 17 deletions pegjs/sqlite.pegjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2634,26 +2634,11 @@ single_quote_char
/ escape_char

single_char
= [^'\\] // remove \0-\x1F\x7f pnCtrl char [^'\\\0-\x1F\x7f]
= [^'] // remove \0-\x1F\x7f pnCtrl char [^'\\\0-\x1F\x7f]
/ escape_char

escape_char
= "\\'" { return "\\'"; }
/ '\\"' { return '\\"'; }
/ "\\\\" { return "\\\\"; }
/ "\\/" { return "\\/"; }
/ "\\b" { return "\b"; }
/ "\\f" { return "\f"; }
/ "\\n" { return "\n"; }
/ "\\r" { return "\r"; }
/ "\\t" { return "\t"; }
/ "\\u" h1:hexDigit h2:hexDigit h3:hexDigit h4:hexDigit {
return String.fromCharCode(parseInt("0x" + h1 + h2 + h3 + h4));
}
/ "\\" { return "\\"; }
/ "''" { return "''" }
/ '""' { return '""' }
/ '``' { return '``' }
= "''"

line_terminator
= [\n\r]
Expand Down
8 changes: 6 additions & 2 deletions test/sqlite.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,11 @@ describe('sqlite', () => {
})
})
it('should support LIKE with ESCAPE', () => {
const sql = `SELECT * FROM table_name WHERE column_name LIKE '%pattern%' ESCAPE '\'`
expect(getParsedSql(sql)).to.be.equal(`SELECT * FROM "table_name" WHERE "column_name" LIKE '%pattern%' ESCAPE '\'`)
const sql = `SELECT * FROM table_name WHERE column_name LIKE '%pattern%' ESCAPE 'x'`
expect(getParsedSql(sql)).to.be.equal(`SELECT * FROM "table_name" WHERE "column_name" LIKE '%pattern%' ESCAPE 'x'`)
Comment on lines -269 to +270
Copy link
Contributor Author

@sgress454 sgress454 Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My previous PR added this test which I thought proved that the desired query would work, but this really just evaluated to ESCAPE ''. Working with escapes can really do your head in! Updating to just show that ESCAPE works with LIKE, and added a separate test for the \' case.

})
it('should allow single backslash without escaping', () => {
const sql = `SELECT * FROM table_name WHERE column_name LIKE '\\_%' ESCAPE '\\'`
expect(getParsedSql(sql)).to.be.equal(`SELECT * FROM "table_name" WHERE "column_name" LIKE '\\_%' ESCAPE '\\'`)
})
})