Skip to content

Commit 5f17ae0

Browse files
committed
fix: mypy issues
Locally mypy started pointing out more issues, mainly missing Optional indicators. This PR aims to resolve those bugs.
1 parent 59eaebb commit 5f17ae0

File tree

8 files changed

+18
-9
lines changed

8 files changed

+18
-9
lines changed

tableauserverclient/models/data_freshness_policy_item.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ def interval_item(self) -> Optional[list[str]]:
6666
return self._interval_item
6767

6868
@interval_item.setter
69-
def interval_item(self, value: list[str]):
69+
def interval_item(self, value: Optional[list[str]]):
7070
self._interval_item = value
7171

7272
@property
@@ -127,15 +127,15 @@ def fresh_every_schedule(self) -> Optional[FreshEvery]:
127127
return self._fresh_every_schedule
128128

129129
@fresh_every_schedule.setter
130-
def fresh_every_schedule(self, value: FreshEvery):
130+
def fresh_every_schedule(self, value: Optional[FreshEvery]):
131131
self._fresh_every_schedule = value
132132

133133
@property
134134
def fresh_at_schedule(self) -> Optional[FreshAt]:
135135
return self._fresh_at_schedule
136136

137137
@fresh_at_schedule.setter
138-
def fresh_at_schedule(self, value: FreshAt):
138+
def fresh_at_schedule(self, value: Optional[FreshAt]):
139139
self._fresh_at_schedule = value
140140

141141
@classmethod

tableauserverclient/models/flow_item.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ def description(self) -> Optional[str]:
129129
return self._description
130130

131131
@description.setter
132-
def description(self, value: str) -> None:
132+
def description(self, value: Optional[str]) -> None:
133133
self._description = value
134134

135135
@property

tableauserverclient/models/group_item.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ def name(self) -> Optional[str]:
9292
return self._name
9393

9494
@name.setter
95-
def name(self, value: str) -> None:
95+
def name(self, value: Optional[str]) -> None:
9696
self._name = value
9797

9898
@property

tableauserverclient/models/groupset_item.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,14 @@ def __str__(self) -> str:
2424
def __repr__(self) -> str:
2525
return self.__str__()
2626

27+
@property
28+
def name(self) -> Optional[str]:
29+
return self._name
30+
31+
@name.setter
32+
def name(self, value: Optional[str]) -> None:
33+
self._name = value
34+
2735
@classmethod
2836
def from_response(cls, response: bytes, ns: dict[str, str]) -> list["GroupSetItem"]:
2937
parsed_response = fromstring(response)

tableauserverclient/models/project_item.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ def name(self) -> Optional[str]:
194194
return self._name
195195

196196
@name.setter
197-
def name(self, value: str) -> None:
197+
def name(self, value: Optional[str]) -> None:
198198
self._name = value
199199

200200
@property

tableauserverclient/models/user_item.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ def name(self) -> Optional[str]:
185185
return self._name
186186

187187
@name.setter
188-
def name(self, value: str):
188+
def name(self, value: Optional[str]):
189189
self._name = value
190190

191191
# valid: username, domain/username, username@domain, domain/username@email

tableauserverclient/models/workbook_item.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -330,15 +330,15 @@ def thumbnails_user_id(self) -> Optional[str]:
330330
return self._thumbnails_user_id
331331

332332
@thumbnails_user_id.setter
333-
def thumbnails_user_id(self, value: str):
333+
def thumbnails_user_id(self, value: Optional[str]):
334334
self._thumbnails_user_id = value
335335

336336
@property
337337
def thumbnails_group_id(self) -> Optional[str]:
338338
return self._thumbnails_group_id
339339

340340
@thumbnails_group_id.setter
341-
def thumbnails_group_id(self, value: str):
341+
def thumbnails_group_id(self, value: Optional[str]):
342342
self._thumbnails_group_id = value
343343

344344
@property

test/test_custom_view.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,7 @@ def test_update(self) -> None:
132132
the_custom_view = TSC.CustomViewItem("1d0304cd-3796-429f-b815-7258370b9b74", name="Best test ever")
133133
the_custom_view._id = "1f951daf-4061-451a-9df1-69a8062664f2"
134134
the_custom_view.owner = TSC.UserItem()
135+
assert the_custom_view.owner is not None # for mypy
135136
the_custom_view.owner.id = "dd2239f6-ddf1-4107-981a-4cf94e415794"
136137
the_custom_view = self.server.custom_views.update(the_custom_view)
137138

0 commit comments

Comments
 (0)