fix: mypy issues

Locally mypy started pointing out more issues, mainly missing
Optional indicators. This PR aims to resolve those bugs.

Author: jorwoods

tableauserverclient/models/data_freshness_policy_item.py

@@ -66,7 +66,7 @@ def interval_item(self) -> Optional[list[str]]:
             return self._interval_item
 
         @interval_item.setter
-        def interval_item(self, value: list[str]):
+        def interval_item(self, value: Optional[list[str]]):
             self._interval_item = value
 
         @property
@@ -127,15 +127,15 @@ def fresh_every_schedule(self) -> Optional[FreshEvery]:
         return self._fresh_every_schedule
 
     @fresh_every_schedule.setter
-    def fresh_every_schedule(self, value: FreshEvery):
+    def fresh_every_schedule(self, value: Optional[FreshEvery]):
         self._fresh_every_schedule = value
 
     @property
     def fresh_at_schedule(self) -> Optional[FreshAt]:
         return self._fresh_at_schedule
 
     @fresh_at_schedule.setter
-    def fresh_at_schedule(self, value: FreshAt):
+    def fresh_at_schedule(self, value: Optional[FreshAt]):
         self._fresh_at_schedule = value
 
     @classmethod

tableauserverclient/models/flow_item.py

@@ -129,7 +129,7 @@ def description(self) -> Optional[str]:
         return self._description
 
     @description.setter
-    def description(self, value: str) -> None:
+    def description(self, value: Optional[str]) -> None:
         self._description = value
 
     @property

tableauserverclient/models/group_item.py

@@ -92,7 +92,7 @@ def name(self) -> Optional[str]:
         return self._name
 
     @name.setter
-    def name(self, value: str) -> None:
+    def name(self, value: Optional[str]) -> None:
         self._name = value
 
     @property

tableauserverclient/models/groupset_item.py

@@ -24,6 +24,14 @@ def __str__(self) -> str:
     def __repr__(self) -> str:
         return self.__str__()
 
+    @property
+    def name(self) -> Optional[str]:
+        return self._name
+
+    @name.setter
+    def name(self, value: Optional[str]) -> None:
+        self._name = value
+
     @classmethod
     def from_response(cls, response: bytes, ns: dict[str, str]) -> list["GroupSetItem"]:
         parsed_response = fromstring(response)

tableauserverclient/models/project_item.py

@@ -194,7 +194,7 @@ def name(self) -> Optional[str]:
         return self._name
 
     @name.setter
-    def name(self, value: str) -> None:
+    def name(self, value: Optional[str]) -> None:
         self._name = value
 
     @property

tableauserverclient/models/user_item.py

@@ -186,7 +186,7 @@ def name(self) -> Optional[str]:
         return self._name
 
     @name.setter
-    def name(self, value: str):
+    def name(self, value: Optional[str]):
         self._name = value
 
     # valid: username, domain/username, username@domain, domain/username@email

tableauserverclient/models/workbook_item.py

@@ -330,15 +330,15 @@ def thumbnails_user_id(self) -> Optional[str]:
         return self._thumbnails_user_id
 
     @thumbnails_user_id.setter
-    def thumbnails_user_id(self, value: str):
+    def thumbnails_user_id(self, value: Optional[str]):
         self._thumbnails_user_id = value
 
     @property
     def thumbnails_group_id(self) -> Optional[str]:
         return self._thumbnails_group_id
 
     @thumbnails_group_id.setter
-    def thumbnails_group_id(self, value: str):
+    def thumbnails_group_id(self, value: Optional[str]):
         self._thumbnails_group_id = value
 
     @property

test/test_custom_view.py

@@ -115,7 +115,6 @@ def test_populate_image_with_options(server: TSC.Server) -> None:
         server.custom_views.populate_image(single_view, req_option)
         assert response == single_view.image
 
-
 def test_populate_image_missing_id(server: TSC.Server) -> None:
     single_view = TSC.CustomViewItem()
     single_view._id = None
@@ -141,9 +140,11 @@ def test_update(server: TSC.Server) -> None:
         the_custom_view = TSC.CustomViewItem("1d0304cd-3796-429f-b815-7258370b9b74", name="Best test ever")
         the_custom_view._id = "1f951daf-4061-451a-9df1-69a8062664f2"
         the_custom_view.owner = TSC.UserItem()
+        assert the_custom_view.owner is not None  # for mypy
         the_custom_view.owner.id = "dd2239f6-ddf1-4107-981a-4cf94e415794"
         the_custom_view = server.custom_views.update(the_custom_view)
 
+    assert isinstance(the_custom_view, TSC.CustomViewItem)
     assert "1f951daf-4061-451a-9df1-69a8062664f2" == the_custom_view.id
     if the_custom_view.owner:
         assert "dd2239f6-ddf1-4107-981a-4cf94e415794" == the_custom_view.owner.id